From kde-core-devel  Sat Aug 03 17:16:03 2013
From: Dawit A <adawit () kde ! org>
Date: Sat, 03 Aug 2013 17:16:03 +0000
To: kde-core-devel
Subject: Re: Broken tests in kdelibs due to kio change
Message-Id: <CALa28R7RaK7SNSxejTmx2e6aDDDoX529i5dWxVxUKr4TjLC3nQ () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=137555023429720
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--089e011832ce419bc804e30e3df7"

--089e011832ce419bc804e30e3df7
Content-Type: text/plain; charset=UTF-8

Hmm... I fail to see how my changes break those unit tests. Perhaps
changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to
look into it.


On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <aacid@kde.org> wrote:

> Dawit, kdelibs people, there are 4 tests that broke in
> very-close-to-release
> 4.11 branch with a change from yesterday to kio.
>
> http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/
>
> Can you guys please have a look and fix those failing tests?
>
> Also please please please make sure you either run the tests before
> commiting
> changes so late in the release cycle *and* even if you run them please
> check
> with jenkins to see his opinion on your changes :)
>
> Cheers,
>   Albert
>

--089e011832ce419bc804e30e3df7
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hmm... I fail to see how my changes break those unit tests=
. Perhaps changing fileundomanager from NoGui to Gui did it? Anyhow, I will=
 try to look into it.<div class=3D"gmail_extra"><br><br><div class=3D"gmail=
_quote">


On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <span dir=3D"ltr">&lt;<a=
 href=3D"mailto:aacid@kde.org" target=3D"_blank">aacid@kde.org</a>&gt;</spa=
n> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b=
order-left:1px #ccc solid;padding-left:1ex">


Dawit, kdelibs people, there are 4 tests that broke in very-close-to-releas=
e<br>
4.11 branch with a change from yesterday to kio.<br>
<br>
<a href=3D"http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/7=
35/" target=3D"_blank">http://build.kde.org/view/KDE%20SC%20stable/job/kdel=
ibs_stable/735/</a><br>
<br>
Can you guys please have a look and fix those failing tests?<br>
<br>
Also please please please make sure you either run the tests before commiti=
ng<br>
changes so late in the release cycle *and* even if you run them please chec=
k<br>
with jenkins to see his opinion on your changes :)<br>
<br>
Cheers,<br>
=C2=A0 Albert<br>
</blockquote></div><br></div></div>

--089e011832ce419bc804e30e3df7--