[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for
From: "Commit Hook" <null () kde ! org>
Date: 2013-07-04 21:33:31
Message-ID: 20130704213331.5150.22153 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111371/#review35603
-----------------------------------------------------------
This review has been submitted with commit f0a932154766cd9014fc4f79cfefcf8b92b82cfc \
by Luca Beltrame to branch KDE/4.10.
- Commit Hook
On July 2, 2013, 6:58 p.m., Vadim Zhukov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111371/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:58 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Currently, PYTHON_INSTALL macro in PythonMacros.cmake creates same target \
> "compile_python_files" for all Python modules. This somehow works for Make-based \
> builds, but breaks when using Ninja backend for CMake. CMake itself says that it \
> does not guarantee that targets with same name will ever work.
> The patch creates unique target for each python module being pre-compiled and \
> installed.
> The patch can be applied without modifications to 4.10 and 4.11, too.
>
>
> Diffs
> -----
>
> cmake/modules/PythonMacros.cmake 95c9315
>
> Diff: http://git.reviewboard.kde.org/r/111371/diff/
>
>
> Testing
> -------
>
> OpenBSD-CURRENT, PyKDE 4.10.4 and 4.10.5.
>
>
> Thanks,
>
> Vadim Zhukov
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111371/">http://git.reviewboard.kde.org/r/111371/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f0a932154766cd9014fc4f79cfefcf8b92b82cfc by Luca Beltrame to \
branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 2nd, 2013, 6:58 p.m. UTC, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated July 2, 2013, 6:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, PYTHON_INSTALL macro in PythonMacros.cmake creates same \
target "compile_python_files" for all Python modules. This somehow works \
for Make-based builds, but breaks when using Ninja backend for CMake. CMake itself \
says that it does not guarantee that targets with same name will ever work.
The patch creates unique target for each python module being pre-compiled and \
installed.
The patch can be applied without modifications to 4.10 and 4.11, too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">OpenBSD-CURRENT, PyKDE 4.10.4 and 4.10.5.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/PythonMacros.cmake <span style="color: grey">(95c9315)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111371/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic