This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/ 

This review has been submitted with commit f0a932154766cd9014fc4f79cfefcf8b92b82cfc by Luca Beltrame to branch KDE/4.10.

- Commit


On July 2nd, 2013, 6:58 p.m. UTC, Vadim Zhukov wrote:

Review request for kdelibs.
By Vadim Zhukov.

Updated July 2, 2013, 6:58 p.m.

Description 

Currently, PYTHON_INSTALL macro in PythonMacros.cmake creates same target "compile_python_files" for all Python modules. This somehow works for Make-based builds, but breaks when using Ninja backend for CMake. CMake itself says that it does not guarantee that targets with same name will ever work.

The patch creates unique target for each python module being pre-compiled and installed.

The patch can be applied without modifications to 4.10 and 4.11, too.

Testing 

OpenBSD-CURRENT, PyKDE 4.10.4 and 4.10.5.

Diffs

  • cmake/modules/PythonMacros.cmake (95c9315)

View Diff