[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 110964: kioclient: error messages do not identify their source
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2013-06-11 20:11:53
Message-ID: 20130611201153.27671.60091 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110964/
-----------------------------------------------------------

Review request for KDE Runtime.


Description
-------

While investigating another problem (which turned out to be not the fault of KDE at \
all), I encountered this mysterious message on stderr:

Syntax Error: Not enough arguments

It took a long time to track down the source of this message and find out that it was \
from kioexec.  If kioexec had given its name in the error message, as most Unix \
commands do, then the source of the message would have been obvious and made \
investigation easier.


Diffs
-----

  kioclient/kioclient.cpp d879980 

Diff: http://git.reviewboard.kde.org/r/110964/diff/


Testing
-------

Built kioclient with these changes, verified error message output.

$ kioclient exec
kioclient: Syntax error, not enough arguments
$ kioclient exec a b c
kioclient: Syntax error, too many arguments
$ kioclient foo
kioclient: Syntax error, unknown command 'foo'
$


Thanks,

Jonathan Marten


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110964/">http://git.reviewboard.kde.org/r/110964/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime.</div>
<div>By Jonathan Marten.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While investigating another problem (which turned out to be not the \
fault of KDE at all), I encountered this mysterious message on stderr:

Syntax Error: Not enough arguments

It took a long time to track down the source of this message and find out that it was \
from kioexec.  If kioexec had given its name in the error message, as most Unix \
commands do, then the source of the message would have been obvious and made \
investigation easier. </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kioclient with these changes, verified error message output.

$ kioclient exec
kioclient: Syntax error, not enough arguments
$ kioclient exec a b c
kioclient: Syntax error, too many arguments
$ kioclient foo
kioclient: Syntax error, unknown command &#39;foo&#39;
$
</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioclient/kioclient.cpp <span style="color: grey">(d879980)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110964/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic