From kde-core-devel Tue Jun 11 20:11:53 2013 From: "Jonathan Marten" Date: Tue, 11 Jun 2013 20:11:53 +0000 To: kde-core-devel Subject: Review Request 110964: kioclient: error messages do not identify their source Message-Id: <20130611201153.27671.60091 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=137098155919700 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5563424709846171491==" --===============5563424709846171491== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110964/ ----------------------------------------------------------- Review request for KDE Runtime. Description ------- While investigating another problem (which turned out to be not the fault of KDE at all), I encountered this mysterious message on stderr: Syntax Error: Not enough arguments It took a long time to track down the source of this message and find out that it was from kioexec. If kioexec had given its name in the error message, as most Unix commands do, then the source of the message would have been obvious and made investigation easier. Diffs ----- kioclient/kioclient.cpp d879980 Diff: http://git.reviewboard.kde.org/r/110964/diff/ Testing ------- Built kioclient with these changes, verified error message output. $ kioclient exec kioclient: Syntax error, not enough arguments $ kioclient exec a b c kioclient: Syntax error, too many arguments $ kioclient foo kioclient: Syntax error, unknown command 'foo' $ Thanks, Jonathan Marten --===============5563424709846171491== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110964/

Review request for KDE Runtime.

By Jonathan Marten.

Description

While investigating another problem (which turned out to be not the fault of KDE at all), I encountered this mysterious message on stderr:

Syntax Error: Not enough arguments

It took a long time to track down the source of this message and find out that it was from kioexec.  If kioexec had given its name in the error message, as most Unix commands do, then the source of the message would have been obvious and made investigation easier.

Testing

Built kioclient with these changes, verified error message output.

$ kioclient exec
kioclient: Syntax error, not enough arguments
$ kioclient exec a b c
kioclient: Syntax error, too many arguments
$ kioclient foo
kioclient: Syntax error, unknown command 'foo'
$

Diffs

kioclient/kioclient.cpp (d879980)

--===============5563424709846171491==--