[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Device notifier: show mounted device and path
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2012-10-07 14:55:36
Message-ID: 20121007145536.21381.24964 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106755/
-----------------------------------------------------------
Review request for KDE Base Apps and Plasma.
Description
-------
If a removable device is mounted using the Plasma device notifier, there is no \
indication of what the Unix name of the device is or where it is mounted. This \
information may be useful to the user for (a) accessing the mounted device from \
non-KDE applications, or (b) troubleshooting mounting or unmounting problems.
The attached patch shows this information when the device is hovered over, just above \
the "N actions for this device" text. Depending on whether or not the device is \
mounted, there are three possibilities that can be shown here:
/dev/XXX when not mounted
/dev/XXX mounted on /media/YYYY when mounted
/dev/XXX mounted if mounted but the mount point is not available
Please be gentle, this is my first QML patch :-)
This addresses bug 196939.
http://bugs.kde.org/show_bug.cgi?id=196939
Diffs
-----
plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 2a9b3f7
Diff: http://git.reviewboard.kde.org/r/106755/diff/
Testing
-------
Built kde-workspace with this change, observed operation and display of device \
notifier with a selection of removable devices.
Screenshots
-----------
Device notifier with mounted device
http://git.reviewboard.kde.org/r/106755/s/756/
Thanks,
Jonathan Marten
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106755/">http://git.reviewboard.kde.org/r/106755/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and Plasma.</div>
<div>By Jonathan Marten.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If a removable device is mounted using the Plasma device notifier, there \
is no indication of what the Unix name of the device is or where it is mounted. This \
information may be useful to the user for (a) accessing the mounted device from \
non-KDE applications, or (b) troubleshooting mounting or unmounting problems.
The attached patch shows this information when the device is hovered over, just above \
the "N actions for this device" text. Depending on whether or not the \
device is mounted, there are three possibilities that can be shown here:
/dev/XXX when not mounted
/dev/XXX mounted on /media/YYYY when mounted
/dev/XXX mounted if mounted but the mount point is not available
Please be gentle, this is my first QML patch :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with this change, observed operation and display of \
device notifier with a selection of removable devices. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=196939">196939</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span \
style="color: grey">(2a9b3f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106755/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106755/s/756/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/07/196939_400x100.png" \
style="border: 1px black solid;" alt="Device notifier with mounted device" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic