From kde-core-devel Sun Oct 07 14:55:36 2012 From: "Jonathan Marten" Date: Sun, 07 Oct 2012 14:55:36 +0000 To: kde-core-devel Subject: Review Request: Device notifier: show mounted device and path Message-Id: <20121007145536.21381.24964 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134962177101502 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7906764228430303620==" --===============7906764228430303620== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/ ----------------------------------------------------------- Review request for KDE Base Apps and Plasma. Description ------- If a removable device is mounted using the Plasma device notifier, there is= no indication of what the Unix name of the device is or where it is mounte= d. This information may be useful to the user for (a) accessing the mounte= d device from non-KDE applications, or (b) troubleshooting mounting or unmo= unting problems. The attached patch shows this information when the device is hovered over, = just above the "N actions for this device" text. Depending on whether or n= ot the device is mounted, there are three possibilities that can be shown h= ere: /dev/XXX when not mounted /dev/XXX mounted on /media/YYYY when mounted /dev/XXX mounted if mounted but the mount point is not = available Please be gentle, this is my first QML patch :-) This addresses bug 196939. http://bugs.kde.org/show_bug.cgi?id=3D196939 Diffs ----- plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml = 2a9b3f7 = Diff: http://git.reviewboard.kde.org/r/106755/diff/ Testing ------- Built kde-workspace with this change, observed operation and display of dev= ice notifier with a selection of removable devices. Screenshots ----------- Device notifier with mounted device http://git.reviewboard.kde.org/r/106755/s/756/ Thanks, Jonathan Marten --===============7906764228430303620== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106755/

Review request for KDE Base Apps and Plasma.
By Jonathan Marten.

Descripti= on 

If a removable device is mounted using the Plasma device not=
ifier, there is no indication of what the Unix name of the device is or whe=
re it is mounted.  This information may be useful to the user for (a) acces=
sing the mounted device from non-KDE applications, or (b) troubleshooting m=
ounting or unmounting problems.

The attached patch shows this information when the device is hovered over, =
just above the "N actions for this device" text.  Depending on wh=
ether or not the device is mounted, there are three possibilities that can =
be shown here:

  /dev/XXX                           when not mounted
  /dev/XXX mounted on /media/YYYY    when mounted
  /dev/XXX mounted                   if mounted but the mount point is not =
available

Please be gentle, this is my first QML patch :-)

Testing <= /h1> 
Built kde-workspace with this change, observed operation and=
 display of device notifier with a selection of removable devices.
Bugs: 196939

Diffs=

  • plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.q= ml (2a9b3f7)

View Diff

Screensho= ts

3D"Device
--===============7906764228430303620==--