[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Broken build of KDE Base Apps and unauthorized increase in dependency
From:       Dawit A <adawit () kde ! org>
Date:       2012-09-13 16:06:01
Message-ID: CALa28R5hc+ai+KVz3t9LVDkz28nTVOEZAd8t4JCdMuHH57Y6Sw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Sep 13, 2012 at 11:39 AM, Ralf Jung <post@ralfj.de> wrote:

> Hi,
>
> > First, sorry I confused kdelibs with kde-baseapps in this response. So
> > forget what I said about changes being merged back into 4.10 branch by
> > David. Anyhow, I have now attempted to fix this issue as reported here.
> See
> >
> >
> http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b
> > .
> >
> > However this fix does not really work. That is compile will fail if KDE
> > version is changed to 4.9.2 as well because Qt's moc processor does not
> > seem to correctly handle #if macros. So my question is whether it would
> be
> > acceptable for me to revert this change from the git 4.9 branch and
> simply
> > leave it as it was in the git master branch ? IOW, kde-baseapps 4.10
> > release will have a minimum requirement of kdelibs 4.9.2 ?
>


> To make things worse, this commit cherry-picked onto kde-baseapps master
> breaks compilation against kdelibs master. I had to revert 965fc6b3 to
> succeed with compilation.


 Yes, that is why there a pending review to fix it: See
https://git.reviewboard.kde.org/r/106438/.

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Thu, Sep 13, 2012 at 11:39 AM, Ralf Jung <span \
dir="ltr">&lt;<a href="mailto:post@ralfj.de" \
target="_blank">post@ralfj.de</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

Hi,<br>
<div class="im"><br>
&gt; First, sorry I confused kdelibs with kde-baseapps in this response. So<br>
&gt; forget what I said about changes being merged back into 4.10 branch by<br>
&gt; David. Anyhow, I have now attempted to fix this issue as reported here. See<br>
&gt;<br>
&gt; <a href="http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b" \
target="_blank">http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b</a><br>
 &gt; .<br>
&gt;<br>
&gt; However this fix does not really work. That is compile will fail if KDE<br>
&gt; version is changed to 4.9.2 as well because Qt&#39;s moc processor does not<br>
&gt; seem to correctly handle #if macros. So my question is whether it would be<br>
&gt; acceptable for me to revert this change from the git 4.9 branch and simply<br>
&gt; leave it as it was in the git master branch ? IOW, kde-baseapps 4.10<br>
&gt; release will have a minimum requirement of kdelibs 4.9.2 \
?<br></div></blockquote><div>  </div><blockquote class="gmail_quote" style="margin:0 \
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"> </div>To make \
things worse, this commit cherry-picked onto kde-baseapps master<br> breaks \
compilation against kdelibs master. I had to revert 965fc6b3 to<br> succeed with \
compilation.</blockquote><div><br></div><div>  <span \
style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">Yes, \
that is why there a pending review to fix it: See  </span><a \
href="https://git.reviewboard.kde.org/r/106438/" target="_blank" \
style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">https://git.reviewboard.kde.org/r/106438/</a><span \
style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">.</span></div>


</div>



_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]