From kde-release-team Thu Sep 13 16:06:01 2012 From: Dawit A Date: Thu, 13 Sep 2012 16:06:01 +0000 To: kde-release-team Subject: Re: Broken build of KDE Base Apps and unauthorized increase in dependency Message-Id: X-MARC-Message: https://marc.info/?l=kde-release-team&m=134755245224897 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8375614823293081052==" --===============8375614823293081052== Content-Type: multipart/alternative; boundary=e89a8fb2024c390f5004c9977e4d --e89a8fb2024c390f5004c9977e4d Content-Type: text/plain; charset=UTF-8 On Thu, Sep 13, 2012 at 11:39 AM, Ralf Jung wrote: > Hi, > > > First, sorry I confused kdelibs with kde-baseapps in this response. So > > forget what I said about changes being merged back into 4.10 branch by > > David. Anyhow, I have now attempted to fix this issue as reported here. > See > > > > > http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b > > . > > > > However this fix does not really work. That is compile will fail if KDE > > version is changed to 4.9.2 as well because Qt's moc processor does not > > seem to correctly handle #if macros. So my question is whether it would > be > > acceptable for me to revert this change from the git 4.9 branch and > simply > > leave it as it was in the git master branch ? IOW, kde-baseapps 4.10 > > release will have a minimum requirement of kdelibs 4.9.2 ? > > To make things worse, this commit cherry-picked onto kde-baseapps master > breaks compilation against kdelibs master. I had to revert 965fc6b3 to > succeed with compilation. Yes, that is why there a pending review to fix it: See https://git.reviewboard.kde.org/r/106438/. --e89a8fb2024c390f5004c9977e4d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Thu, Sep 13, 2012 at 11:39 AM, Ralf J= ung <post@ralfj.de> wrote:
Hi,

> First, sorry I confused kdelibs with kde-baseapps in this response. So=
> forget what I said about changes being merged back into 4.10 branch by=
> David. Anyhow, I have now attempted to fix this issue as reported here= . See
>
> http://commits.kde.org/kde-baseapps/f0= d5e062bf0452258d337d7dcb2edd2eefa1c37b
> .
>
> However this fix does not really work. That is compile will fail if KD= E
> version is changed to 4.9.2 as well because Qt's moc processor doe= s not
> seem to correctly handle #if macros. So my question is whether it woul= d be
> acceptable for me to revert this change from the git 4.9 branch and si= mply
> leave it as it was in the git master branch ? IOW, kde-baseapps 4.10 > release will have a minimum requirement of kdelibs 4.9.2 ?
=C2=A0
To make things worse, this commit cherry-picked onto kde-baseapps mas= ter
breaks compilation against kdelibs master. I had to revert 965fc6b3 to
succeed with compilation.

=C2=A0Yes, that is why there a pending review to fix = it: See=C2=A0https://git.reviewboard.= kde.org/r/106438/.
--e89a8fb2024c390f5004c9977e4d-- --===============8375614823293081052== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team --===============8375614823293081052==--