[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: konqueror: strip new line character from URL on paste automatically
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2012-08-25 19:49:07
Message-ID: 20120825194907.25519.32628 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106184/#review17997
-----------------------------------------------------------
konqueror/src/konqcombo.cpp
<http://git.reviewboard.kde.org/r/106184/#comment14232>
Please normalize the connect:
connect(edit, SIGNAL(textEdited(QString)), this, SLOT(slotTextEdited(QString)));
- Rolf Eike Beer
On Aug. 25, 2012, 7:40 p.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106184/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2012, 7:40 p.m.)
>
>
> Review request for KDE Base Apps and David Faure.
>
>
> Description
> -------
>
> This patch removes line-breaking chars when an URL is entered.
> Very handy if you paste URLs from e.g. an email which shows the complete URL broken into multiple lines.
>
>
> This addresses bug 159002.
> http://bugs.kde.org/show_bug.cgi?id=159002
>
>
> Diffs
> -----
>
> konqueror/src/konqcombo.h 5c86fcd
> konqueror/src/konqcombo.cpp 8169aec
>
> Diff: http://git.reviewboard.kde.org/r/106184/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Martin Koller
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106184/">http://git.reviewboard.kde.org/r/106184/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106184/diff/1/?file=81135#file81135line145" style="color: black; \
font-weight: bold; text-decoration: underline;">konqueror/src/konqcombo.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KonqCombo::KonqCombo( \
QWidget *parent )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">145</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span \
class="p">(</span> <span class="n">edit</span><span class="p">,</span> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">textEdited</span><span class="p">(</span><span class="k">const</span> \
<span class="n">QString</span> <span class="o">&</span><span class="p">)),</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">146</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotTextEdited</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="p">))</span> <span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Please normalize the connect:
connect(edit, SIGNAL(textEdited(QString)), this, SLOT(slotTextEdited(QString)));</pre>
</div>
<br />
<p>- Rolf Eike</p>
<br />
<p>On August 25th, 2012, 7:40 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2012, 7:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes line-breaking chars when \
an URL is entered. Very handy if you paste URLs from e.g. an email which shows the complete URL broken \
into multiple lines.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=159002">159002</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqcombo.h <span style="color: grey">(5c86fcd)</span></li>
<li>konqueror/src/konqcombo.cpp <span style="color: grey">(8169aec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106184/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic