--===============3868804168040111161== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/#review17997 ----------------------------------------------------------- konqueror/src/konqcombo.cpp Please normalize the connect: = connect(edit, SIGNAL(textEdited(QString)), this, SLOT(slotTextEdited(QS= tring))); - Rolf Eike Beer On Aug. 25, 2012, 7:40 p.m., Martin Koller wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106184/ > ----------------------------------------------------------- > = > (Updated Aug. 25, 2012, 7:40 p.m.) > = > = > Review request for KDE Base Apps and David Faure. > = > = > Description > ------- > = > This patch removes line-breaking chars when an URL is entered. > Very handy if you paste URLs from e.g. an email which shows the complete = URL broken into multiple lines. > = > = > This addresses bug 159002. > http://bugs.kde.org/show_bug.cgi?id=3D159002 > = > = > Diffs > ----- > = > konqueror/src/konqcombo.h 5c86fcd = > konqueror/src/konqcombo.cpp 8169aec = > = > Diff: http://git.reviewboard.kde.org/r/106184/diff/ > = > = > Testing > ------- > = > yes > = > = > Thanks, > = > Martin Koller > = > --===============3868804168040111161== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106184/

= =

konqueror/src/konqcombo.cpp (Diff revision 1)
KonqCombo::KonqCombo( QWidget *parent )
		145	connect( edit, SIGNAL(te= xtEdited(const QString &)),
		146	this, SLOT(slotTextEdited(const QString = &)) );

Please normalize the connect:

connect(edit, SIGNAL(textEdited(QString)), this, SLOT(slotTextEdited(QStrin=
g)));

- Rolf Eike

On August 25th, 2012, 7:40 p.m., Martin Koller wrote:

Review request for KDE Base Apps and David Faure.

By Martin Koller.

Updated Aug. 25, 2012, 7:40 p.m.

Descripti= on

This patch removes line-breaking chars when an URL is entere=
d.
Very handy if you paste URLs from e.g. an email which shows the complete UR=
L broken into multiple lines.

Testing <= /h1>

yes

Bugs: 159002

Diffs=

konqueror/src/konqcombo.h (5c86fcd)=
konqueror/src/konqcombo.cpp (8169aec)

--===============3868804168040111161==--