[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add urlChanged signal to ReadOnlyPart
From: "David Faure" <faure () kde ! org>
Date: 2012-08-22 11:18:45
Message-ID: 20120822111845.11686.4001 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106116/#review17858
-----------------------------------------------------------
Looks good, please add @since 4.10 to the signal definition, and commit to KDE/4.10. \
Just one bug:
kparts/part.cpp
<http://git.reviewboard.kde.org/r/106116/#comment14091>
If it didn't change, why emit urlChanged() here?
i.e. I think this line should be kept as m_url = m_originalURL.
- David Faure
On Aug. 21, 2012, 8:35 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106116/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2012, 8:35 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> Add this signal since i found i needed it in Okular, we've solved the problem in a \
> different way, but maybe the next person that needs the signal has it available :-) \
> I don't care to which branch to add it.
>
>
> Diffs
> -----
>
> kparts/part.h 56b64da
> kparts/part.cpp f74bd78
>
> Diff: http://git.reviewboard.kde.org/r/106116/diff/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Albert Astals Cid
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106116/">http://git.reviewboard.kde.org/r/106116/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, please add \
@since 4.10 to the signal definition, and commit to KDE/4.10. Just one bug:</pre> \
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106116/diff/2/?file=79923#file79923line996" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kparts/part.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ReadWritePartPrivate::_k_slotUploadFinished( KJob * )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">994</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">m_url</span></span><span class="hl"> </span><span \
class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n">m_originalURL</span><span class="p">;</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">996</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n"><span class="hl">q</span></span><span class="o"><span \
class="hl">-></span></span><span class="n"><span \
class="hl">setUrl</span></span><span class="p"><span class="hl">(</span></span><span \
class="n">m_originalURL</span><span class="p"><span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it \
didn't change, why emit urlChanged() here? i.e. I think this line should be kept \
as m_url = m_originalURL.</pre> </div>
<br />
<p>- David</p>
<br />
<p>On August 21st, 2012, 8:35 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2012, 8:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add this signal since i found i needed it in Okular, we've solved \
the problem in a different way, but maybe the next person that needs the signal has \
it available :-)
I don't care to which branch to add it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kparts/part.h <span style="color: grey">(56b64da)</span></li>
<li>kparts/part.cpp <span style="color: grey">(f74bd78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106116/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic