This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/ 

Looks good, please add @since 4.10 to the signal definition, and commit to KDE/4.10. Just one bug:

kparts/part.cpp (Diff revision 2) 
void ReadWritePartPrivate::_k_slotUploadFinished( KJob * )
994 
            m_url = m_originalURL;
 996 
            q->setUrl(m_originalURL);
 
If it didn't change, why emit urlChanged() here?
i.e. I think this line should be kept as m_url = m_originalURL.

- David


On August 21st, 2012, 8:35 p.m., Albert Astals Cid wrote:

Review request for kdelibs and David Faure.
By Albert Astals Cid.

Updated Aug. 21, 2012, 8:35 p.m.

Description 

Add this signal since i found i needed it in Okular, we've solved the problem in a different way, but maybe the next person that needs the signal has it available :-)

I don't care to which branch to add it.

Testing 

None

Diffs

  • kparts/part.h (56b64da)
  • kparts/part.cpp (f74bd78)

View Diff