[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: kjs: Implement Date.toJSON
From:       "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date:       2012-07-20 22:22:09
Message-ID: 20120720222209.7373.72122 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105631/#review16171
-----------------------------------------------------------



kjs/CommonIdentifiers.h
<http://git.reviewboard.kde.org/r/105631/#comment12766>

    toJSON is already present and you add toISOString? Are you sure this is=
 the right diff?


- Rolf Eike Beer


On July 20, 2012, 6:57 p.m., Bernd Buschinski wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105631/
> -----------------------------------------------------------
> =

> (Updated July 20, 2012, 6:57 p.m.)
> =

> =

> Review request for kdelibs.
> =

> =

> Description
> -------
> =

> kjs: Implement Date.toJSON
> =

> according to ecmascript edition 5.1r6 - 15.9.5.44 =

> =

> =

> Diffs
> -----
> =

>   kjs/CommonIdentifiers.h 8ee40e8 =

>   kjs/date_object.h ed45720 =

>   kjs/date_object.cpp 8a1fc2c =

> =

> Diff: http://git.reviewboard.kde.org/r/105631/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Bernd Buschinski
> =

>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105631/">http://git.reviewboard.kde.org/r/105631/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105631/diff/1/?file=73994#file73994line59" style="color: black; \
font-weight: bold; text-decoration: underline;">kjs/CommonIdentifiers.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">59</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">    macro(toISOString) \
\</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">toJSON is already present and you add toISOString? Are \
you sure this is the right diff?</pre> </div>
<br />



<p>- Rolf Eike</p>


<br />
<p>On July 20th, 2012, 6:57 p.m., Bernd Buschinski wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>


<p style="color: grey;"><i>Updated July 20, 2012, 6:57 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kjs: Implement Date.toJSON

according to ecmascript edition 5.1r6 - 15.9.5.44 </pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kjs/CommonIdentifiers.h <span style="color: grey">(8ee40e8)</span></li>

 <li>kjs/date_object.h <span style="color: grey">(ed45720)</span></li>

 <li>kjs/date_object.cpp <span style="color: grey">(8a1fc2c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105631/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic