From kde-core-devel Fri Jul 20 22:22:09 2012 From: "Rolf Eike Beer" Date: Fri, 20 Jul 2012 22:22:09 +0000 To: kde-core-devel Subject: Re: Review Request: kjs: Implement Date.toJSON Message-Id: <20120720222209.7373.72122 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134282321306438 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5147152852027915405==" --===============5147152852027915405== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105631/#review16171 ----------------------------------------------------------- kjs/CommonIdentifiers.h toJSON is already present and you add toISOString? Are you sure this is= the right diff? - Rolf Eike Beer On July 20, 2012, 6:57 p.m., Bernd Buschinski wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105631/ > ----------------------------------------------------------- > = > (Updated July 20, 2012, 6:57 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > kjs: Implement Date.toJSON > = > according to ecmascript edition 5.1r6 - 15.9.5.44 = > = > = > Diffs > ----- > = > kjs/CommonIdentifiers.h 8ee40e8 = > kjs/date_object.h ed45720 = > kjs/date_object.cpp 8a1fc2c = > = > Diff: http://git.reviewboard.kde.org/r/105631/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Bernd Buschinski > = > --===============5147152852027915405== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105631/

= =
kjs/CommonIdentifiers.h (Diff revision 1) 


  

 

  

    
    

    59
    
    macro(toISOString) \

  


 





toJSON is already present and you add toISOString? Are you sure this=
 is the right diff?









- Rolf Eike






On July 20th, 2012, 6:57 p.m., Bernd Buschinski wrote:









 

  


Review request for kdelibs.


By Bernd Buschinski.




Updated July 20, 2012, 6:57 p.m.








Descripti=
on 

 

 

  
   
kjs: Implement Date.toJSON

according to ecmascript edition 5.1r6 - 15.9.5.44 

  		
 









Diffs=
 


    

 
  • kjs/CommonIdentifiers.h (8ee40e8)

 
  • kjs/date_object.h (ed45720)
    • 

 
  • kjs/date_object.cpp (8a1fc2c)
    • 





View Diff





  		
 











  

 



--===============5147152852027915405==--