[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: implement support for window.onhashchange
From: "Maks Orlovich" <maksim () kde ! org>
Date: 2012-06-10 19:58:25
Message-ID: 20120610195825.13093.16987 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104946/#review14592
-----------------------------------------------------------
Ship it!
Looks good, except for a few nitpicks.
khtml/ecma/kjs_events.cpp
<http://git.reviewboard.kde.org/r/104946/#comment11540>
5, not 7
khtml/ecma/kjs_window.h
<http://git.reviewboard.kde.org/r/104946/#comment11541>
Add HashChangeEventCtor as well?
- Maks Orlovich
On May 15, 2012, 12:56 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104946/
> -----------------------------------------------------------
> =
> (Updated May 15, 2012, 12:56 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> Implement a custom hashchange event, and make the khtml kpart emit it
> when we are asked to navigate to another anchor, and the ref is
> different.
> =
> =
> Diffs
> -----
> =
> khtml/ecma/kjs_events.h 3727b94 =
> khtml/ecma/kjs_events.cpp e7c7e5b =
> khtml/ecma/kjs_html.h 089b550 =
> khtml/ecma/kjs_html.cpp d64e07c =
> khtml/ecma/kjs_window.h 416b045 =
> khtml/ecma/kjs_window.cpp e75e6e7 =
> khtml/html/html_baseimpl.cpp baa13b5 =
> khtml/khtml_part.cpp 24589e4 =
> khtml/misc/htmlattrs.in 21a2363b =
> khtml/misc/htmlnames.h e3adbe7 =
> khtml/misc/htmlnames.cpp 3b22b6d =
> khtml/xml/dom2_eventsimpl.h 5b452d2 =
> khtml/xml/dom2_eventsimpl.cpp f01a533 =
> =
> Diff: http://git.reviewboard.kde.org/r/104946/diff/
> =
> =
> Testing
> -------
> =
> tested extensively against http://lolcats.iskrembilen.com/
> =
> =
> Thanks,
> =
> Martin Tobias Holmedahl Sandsmark
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104946/">http://git.reviewboard.kde.org/r/104946/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, except for a \
few nitpicks.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104946/diff/3/?file=64502#file64502line1119" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_events.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">const ClassInfo DOMHashChangeEvent::info = { "HashChangeEvent", \
&DOMEvent::info, &DOMHashChangeEventTable, 0 };</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1119</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> initMessageEvent DOMHashChangeEvent::InitHashChangeEvent \
DontDelete|Function 7</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">5, not \
7</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104946/diff/3/?file=64505#file64505line161" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_window.h</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace KJS {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">161</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">MutationEventCtor</span><span class="p">,</span> <span \
class="n">MessageEventCtor</span><span class="p">,</span> <span \
class="n">KeyboardEventCtor</span><span class="p">,</span> <span \
class="n">EventExceptionCtor</span><span class="p">,</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">161</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">MutationEventCtor</span><span class="p">,</span> <span \
class="n">MessageEventCtor</span><span class="p">,</span> <span \
class="n">KeyboardEventCtor</span><span class="p">,</span> <span \
class="n">EventExceptionCtor</span><span class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add \
HashChangeEventCtor as well?</pre> </div>
<br />
<p>- Maks</p>
<br />
<p>On May 15th, 2012, 12:56 p.m., Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated May 15, 2012, 12:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement a custom hashchange event, and make the khtml kpart emit it \
when we are asked to navigate to another anchor, and the ref is different.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested extensively against http://lolcats.iskrembilen.com/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/kjs_events.h <span style="color: grey">(3727b94)</span></li>
<li>khtml/ecma/kjs_events.cpp <span style="color: grey">(e7c7e5b)</span></li>
<li>khtml/ecma/kjs_html.h <span style="color: grey">(089b550)</span></li>
<li>khtml/ecma/kjs_html.cpp <span style="color: grey">(d64e07c)</span></li>
<li>khtml/ecma/kjs_window.h <span style="color: grey">(416b045)</span></li>
<li>khtml/ecma/kjs_window.cpp <span style="color: grey">(e75e6e7)</span></li>
<li>khtml/html/html_baseimpl.cpp <span style="color: grey">(baa13b5)</span></li>
<li>khtml/khtml_part.cpp <span style="color: grey">(24589e4)</span></li>
<li>khtml/misc/htmlattrs.in <span style="color: grey">(21a2363b)</span></li>
<li>khtml/misc/htmlnames.h <span style="color: grey">(e3adbe7)</span></li>
<li>khtml/misc/htmlnames.cpp <span style="color: grey">(3b22b6d)</span></li>
<li>khtml/xml/dom2_eventsimpl.h <span style="color: grey">(5b452d2)</span></li>
<li>khtml/xml/dom2_eventsimpl.cpp <span style="color: grey">(f01a533)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104946/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic