[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: implement support for window.onhashchange
From:       "Martin Tobias Holmedahl Sandsmark" <sandsmark () samfundet ! no>
Date:       2012-05-15 12:56:20
Message-ID: 20120515125620.18994.78409 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104946/
-----------------------------------------------------------

(Updated May 15, 2012, 12:56 p.m.)


Review request for kdelibs.


Changes
-------

fix issues raised so far.


Description
-------

Implement a custom hashchange event, and make the khtml kpart emit it
when we are asked to navigate to another anchor, and the ref is
different.


Diffs (updated)
-----

  khtml/ecma/kjs_events.h 3727b94 =

  khtml/ecma/kjs_events.cpp e7c7e5b =

  khtml/ecma/kjs_html.h 089b550 =

  khtml/ecma/kjs_html.cpp d64e07c =

  khtml/ecma/kjs_window.h 416b045 =

  khtml/ecma/kjs_window.cpp e75e6e7 =

  khtml/html/html_baseimpl.cpp baa13b5 =

  khtml/khtml_part.cpp 24589e4 =

  khtml/misc/htmlattrs.in 21a2363b =

  khtml/misc/htmlnames.h e3adbe7 =

  khtml/misc/htmlnames.cpp 3b22b6d =

  khtml/xml/dom2_eventsimpl.h 5b452d2 =

  khtml/xml/dom2_eventsimpl.cpp f01a533 =


Diff: http://git.reviewboard.kde.org/r/104946/diff/


Testing
-------

tested extensively against http://lolcats.iskrembilen.com/


Thanks,

Martin Tobias Holmedahl Sandsmark


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104946/">http://git.reviewboard.kde.org/r/104946/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>


<p style="color: grey;"><i>Updated May 15, 2012, 12:56 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix issues raised so far.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement a custom hashchange event, and make the khtml kpart emit it \
when we are asked to navigate to another anchor, and the ref is different.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested extensively against http://lolcats.iskrembilen.com/</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>khtml/ecma/kjs_events.h <span style="color: grey">(3727b94)</span></li>

 <li>khtml/ecma/kjs_events.cpp <span style="color: grey">(e7c7e5b)</span></li>

 <li>khtml/ecma/kjs_html.h <span style="color: grey">(089b550)</span></li>

 <li>khtml/ecma/kjs_html.cpp <span style="color: grey">(d64e07c)</span></li>

 <li>khtml/ecma/kjs_window.h <span style="color: grey">(416b045)</span></li>

 <li>khtml/ecma/kjs_window.cpp <span style="color: grey">(e75e6e7)</span></li>

 <li>khtml/html/html_baseimpl.cpp <span style="color: grey">(baa13b5)</span></li>

 <li>khtml/khtml_part.cpp <span style="color: grey">(24589e4)</span></li>

 <li>khtml/misc/htmlattrs.in <span style="color: grey">(21a2363b)</span></li>

 <li>khtml/misc/htmlnames.h <span style="color: grey">(e3adbe7)</span></li>

 <li>khtml/misc/htmlnames.cpp <span style="color: grey">(3b22b6d)</span></li>

 <li>khtml/xml/dom2_eventsimpl.h <span style="color: grey">(5b452d2)</span></li>

 <li>khtml/xml/dom2_eventsimpl.cpp <span style="color: grey">(f01a533)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104946/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic