[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller
From: "Vishesh Handa" <handa.vish () gmail ! com>
Date: 2012-05-27 13:53:30
Message-ID: 20120527135330.26768.77491 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523/#review14203
-----------------------------------------------------------
Ship it!
Pretty cool!
nepomuk/kcm/statuswidget.cpp
<http://git.reviewboard.kde.org/r/102523/#comment11225>
Commit these icon changes in a separate patch. (No need to open a revie=
w request)
- Vishesh Handa
On May 23, 2012, 3:25 p.m., Kai Uwe Broulik wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102523/
> -----------------------------------------------------------
> =
> (Updated May 23, 2012, 3:25 p.m.)
> =
> =
> Review request for KDE Runtime and Nepomuk.
> =
> =
> Description
> -------
> =
> This little patch adds a "Configure Desktop Search" button to the nepomuk=
controller statuswidget (the little status dialog that appears if you left-=
click on the nepomuk tray icon).
> I know that you can access strigi configuration via the tray icon's conte=
xt menu but I often found myself opening the status dialog and then wanting=
to get to the config dialog from there. Can't harm, can it? :)
> =
> I also added a pause/resume icon to the suspend/resume button.
> =
> =
> Diffs
> -----
> =
> nepomuk/kcm/statuswidget.h b7af01e =
> nepomuk/kcm/statuswidget.cpp a9ece31 =
> nepomuk/kcm/statuswidget.ui ab210c8 =
> =
> Diff: http://git.reviewboard.kde.org/r/102523/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Kai Uwe Broulik
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102523/">http://git.reviewboard.kde.org/r/102523/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pretty cool!</pre> <br \
/>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102523/diff/2/?file=65254#file65254line185" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/kcm/statuswidget.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Nepomuk::StatusWidget::slotSuspendResume()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">185</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_suspendResumeButton</span><span class="o">-></span><span \
class="n">setIcon</span><span class="p">(</span> <span class="n">KIcon</span><span \
class="p">(</span><span class="s">"media-playback-pause"</span><span \
class="p">)</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commit \
these icon changes in a separate patch. (No need to open a review request)</pre> \
</div> <br />
<p>- Vishesh</p>
<br />
<p>On May 23rd, 2012, 3:25 p.m., Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Nepomuk.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 23, 2012, 3:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This little patch adds a "Configure Desktop Search" button to \
the nepomukcontroller statuswidget (the little status dialog that appears if you \
left-click on the nepomuk tray icon). I know that you can access strigi configuration \
via the tray icon's context menu but I often found myself opening the status \
dialog and then wanting to get to the config dialog from there. Can't harm, can \
it? :)
I also added a pause/resume icon to the suspend/resume button.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kcm/statuswidget.h <span style="color: grey">(b7af01e)</span></li>
<li>nepomuk/kcm/statuswidget.cpp <span style="color: grey">(a9ece31)</span></li>
<li>nepomuk/kcm/statuswidget.ui <span style="color: grey">(ab210c8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102523/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic