From kde-core-devel Sun May 27 13:53:30 2012 From: "Vishesh Handa" Date: Sun, 27 May 2012 13:53:30 +0000 To: kde-core-devel Subject: Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Message-Id: <20120527135330.26768.77491 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=133820240403103 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7146173195359485300==" --===============7146173195359485300== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102523/#review14203 ----------------------------------------------------------- Ship it! Pretty cool! nepomuk/kcm/statuswidget.cpp Commit these icon changes in a separate patch. (No need to open a revie= w request) - Vishesh Handa On May 23, 2012, 3:25 p.m., Kai Uwe Broulik wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102523/ > ----------------------------------------------------------- > = > (Updated May 23, 2012, 3:25 p.m.) > = > = > Review request for KDE Runtime and Nepomuk. > = > = > Description > ------- > = > This little patch adds a "Configure Desktop Search" button to the nepomuk= controller statuswidget (the little status dialog that appears if you left-= click on the nepomuk tray icon). > I know that you can access strigi configuration via the tray icon's conte= xt menu but I often found myself opening the status dialog and then wanting= to get to the config dialog from there. Can't harm, can it? :) > = > I also added a pause/resume icon to the suspend/resume button. > = > = > Diffs > ----- > = > nepomuk/kcm/statuswidget.h b7af01e = > nepomuk/kcm/statuswidget.cpp a9ece31 = > nepomuk/kcm/statuswidget.ui ab210c8 = > = > Diff: http://git.reviewboard.kde.org/r/102523/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Kai Uwe Broulik > = > --===============7146173195359485300== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102523/

Ship it!

Pretty coo=
l!

= =

nepomuk/kcm/statuswidget.cpp (Diff revision 2)
void Nepomuk::StatusWidget::slotSuspendResume()
		185	m_suspendResumeButto= n->setIcon( KIcon("media-playback-pause") );

Commit these icon changes in a separate patch. (No need to open a re=
view request)

- Vishesh

On May 23rd, 2012, 3:25 p.m., Kai Uwe Broulik wrote:

Review request for KDE Runtime and Nepomuk.

By Kai Uwe Broulik.

Updated May 23, 2012, 3:25 p.m.

Descripti= on

This little patch adds a "Configure Desktop Search"=
; button to the nepomukcontroller statuswidget (the little status dialog th=
at appears if you left-click on the nepomuk tray icon).
I know that you can access strigi configuration via the tray icon's con=
text menu but I often found myself opening the status dialog and then wanti=
ng to get to the config dialog from there. Can't harm, can it? :)

I also added a pause/resume icon to the suspend/resume button.

Diffs=

nepomuk/kcm/statuswidget.h (b7af01e)
nepomuk/kcm/statuswidget.cpp (a9ece31)
nepomuk/kcm/statuswidget.ui (ab210c8)

--===============7146173195359485300==--