'Re: Review Request: Better stars rating in dolphin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Better stars rating in dolphin
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-05 20:59:15
Message-ID: 20120405205915.26075.6135 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104479/#review12192
-----------------------------------------------------------


This review has been submitted with commit 0cc00c8096700946e8990499d5d9c2b7516915e1 \
by Lamarque V. Souza to branch KDE/4.8.

- Commit Hook


On April 4, 2012, 2:13 p.m., Anant Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104479/
> -----------------------------------------------------------
> 
> (Updated April 4, 2012, 2:13 p.m.)
> 
> 
> Review request for kdelibs and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Patch for bug 171343 (Improving star rating in dolphin)
> As suggested here : https://bugs.kde.org/show_bug.cgi?id=171343#c4
> 
> Now: Clicking once on an empty star= 1 star
> Clicking again = 1/2 star
> Clicking again = Clears the selected star
> 
> 
> Diffs
> -----
> 
> kdeui/widgets/kratingwidget.cpp 811ca0a 
> 
> Diff: http://git.reviewboard.kde.org/r/104479/diff/
> 
> 
> Testing
> -------
> 
> Tested in dolphin
> 
> 
> Thanks,
> 
> Anant Kamath
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104479/">http://git.reviewboard.kde.org/r/104479/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0cc00c8096700946e8990499d5d9c2b7516915e1 by Lamarque V. Souza \
to branch KDE/4.8.</pre>  <br />







<p>- Commit</p>


<br />
<p>On April 4th, 2012, 2:13 p.m., Anant Kamath wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Sebastian Trueg.</div>
<div>By Anant Kamath.</div>


<p style="color: grey;"><i>Updated April 4, 2012, 2:13 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for bug 171343 (Improving star rating in dolphin) As suggested \
here : https://bugs.kde.org/show_bug.cgi?id=171343#c4

Now: Clicking once on an empty star= 1 star
     Clicking again = 1/2 star
     Clicking again = Clears the selected star


</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in dolphin</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/widgets/kratingwidget.cpp <span style="color: grey">(811ca0a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104479/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic