[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: New KPart extension for manupilating a browser engine's settings
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-22 15:49:08
Message-ID: 20120222154908.21737.35581 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/#review10821
-----------------------------------------------------------
This review has been submitted with commit a43057985ce95d043608a5a74555fbb7=
e6f5ed20 by Dawit Alemayehu to branch KDE/4.8.
- Commit Hook
On Feb. 21, 2012, 6:35 p.m., Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103973/
> -----------------------------------------------------------
> =
> (Updated Feb. 21, 2012, 6:35 p.m.)
> =
> =
> Review request for kdelibs and David Faure.
> =
> =
> Description
> -------
> =
> This patch adds a new KPart extension, BrowserSettingsExtension, for sett=
ing as well as accessing a browser engine's properties in a generic fashion=
from KPart plugins. This is yet another step towards making Konqueror's pl=
ugins and settings module independent of the default browser engine in use.=
IOW, they do not have to directly link to a specific browser engine.
> =
> =
> Diffs
> -----
> =
> khtml/khtml_ext.h ced53a3 =
> khtml/khtml_ext.cpp 6e8a846 =
> kparts/htmlextension.h 9833d9a =
> =
> Diff: http://git.reviewboard.kde.org/r/103973/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dawit Alemayehu
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103973/">http://git.reviewboard.kde.org/r/103973/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a43057985ce95d043608a5a74555fbb7e6f5ed20 by Dawit Alemayehu to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 21st, 2012, 6:35 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2012, 6:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a new KPart extension, BrowserSettingsExtension, for \
setting as well as accessing a browser engine's properties in a generic fashion \
from KPart plugins. This is yet another step towards making Konqueror's plugins \
and settings module independent of the default browser engine in use. IOW, they do \
not have to directly link to a specific browser engine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/khtml_ext.h <span style="color: grey">(ced53a3)</span></li>
<li>khtml/khtml_ext.cpp <span style="color: grey">(6e8a846)</span></li>
<li>kparts/htmlextension.h <span style="color: grey">(9833d9a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103973/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic