'Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload
From:       "Commit Hook" <null () kde ! org>
Date:       2012-01-27 15:44:12
Message-ID: 20120127154412.14477.66357 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103740/#review10155
-----------------------------------------------------------


This review has been submitted with commit 92385ff42503710f7b47954776a4fc1fe0637fbb \
by Dawit Alemayehu to branch master.

- Commit Hook


On Jan. 22, 2012, 6:18 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103740/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2012, 6:18 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> If you open several tabs with different URLs, move one of tabs past the last tab, \
> and either press enter or reload, the text of the wrong tab is highlighted \
> eventhough the current active tab is correctly reloaded. The attached patch fixes \
> the bug of the wrong tab being marked as modified. 
> 
> This addresses bug 266369.
> http://bugs.kde.org/show_bug.cgi?id=266369
> 
> 
> Diffs
> -----
> 
> konqueror/src/konqtabs.cpp efaaf87 
> 
> Diff: http://git.reviewboard.kde.org/r/103740/diff/diff
> 
> 
> Testing
> -------
> 
> Follow the testcase steps outlined in the bug report.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103740/">http://git.reviewboard.kde.org/r/103740/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 92385ff42503710f7b47954776a4fc1fe0637fbb by Dawit Alemayehu to \
branch master.</pre>  <br />







<p>- Commit</p>


<br />
<p>On January 22nd, 2012, 6:18 p.m., Dawit Alemayehu wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated Jan. 22, 2012, 6:18 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If you open several tabs with different URLs, move one of tabs past the \
last tab, and either press enter or reload, the text of the wrong tab is highlighted \
eventhough the current active tab is correctly reloaded. The attached patch fixes the \
bug of the wrong tab being marked as modified.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Follow the testcase steps outlined in the bug report.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=266369">266369</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/src/konqtabs.cpp <span style="color: grey">(efaaf87)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103740/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic