From kde-core-devel Fri Jan 27 15:44:12 2012 From: "Commit Hook" Date: Fri, 27 Jan 2012 15:44:12 +0000 To: kde-core-devel Subject: Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload Message-Id: <20120127154412.14477.66357 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132767925721864 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8061151064064793927==" --===============8061151064064793927== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10155 ----------------------------------------------------------- This review has been submitted with commit 92385ff42503710f7b47954776a4fc1f= e0637fbb by Dawit Alemayehu to branch master. - Commit Hook On Jan. 22, 2012, 6:18 p.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103740/ > ----------------------------------------------------------- > = > (Updated Jan. 22, 2012, 6:18 p.m.) > = > = > Review request for KDE Base Apps and David Faure. > = > = > Description > ------- > = > If you open several tabs with different URLs, move one of tabs past the l= ast tab, and either press enter or reload, the text of the wrong tab is hig= hlighted eventhough the current active tab is correctly reloaded. The attac= hed patch fixes the bug of the wrong tab being marked as modified. > = > = > This addresses bug 266369. > http://bugs.kde.org/show_bug.cgi?id=3D266369 > = > = > Diffs > ----- > = > konqueror/src/konqtabs.cpp efaaf87 = > = > Diff: http://git.reviewboard.kde.org/r/103740/diff/diff > = > = > Testing > ------- > = > Follow the testcase steps outlined in the bug report. > = > = > Thanks, > = > Dawit Alemayehu > = > --===============8061151064064793927== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103740/ 

This revie=
w has been submitted with commit 92385ff42503710f7b47954776a4fc1fe0637fbb b=
y Dawit Alemayehu to branch master.

- Commit


On January 22nd, 2012, 6:18 p.m., Dawit Alemayehu wrote:

Review request for KDE Base Apps and David Faure.
By Dawit Alemayehu.

Updated Jan. 22, 2012, 6:18 p.m.

Descripti= on 

If you open several tabs with different URLs, move one of ta=
bs past the last tab, and either press enter or reload, the text of the wro=
ng tab is highlighted eventhough the current active tab is correctly reload=
ed. The attached patch fixes the bug of the wrong tab being marked as modif=
ied.

Testing <= /h1> 
Follow the testcase steps outlined in the bug report.
Bugs: 266369

Diffs=

  • konqueror/src/konqtabs.cpp (efaaf87)

View Diff
--===============8061151064064793927==--