[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: fix infinite recurssion in kcategorizedview
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-12-04 8:30:08
Message-ID: 20111204083008.29800.5467 () vidsolbach ! de
[Download RAW message or body]
> On Dec. 3, 2011, 1:12 p.m., Ruurd Pels wrote:
> > kdeui/itemviews/kcategorizedview.cpp, line 1378
> > <http://git.reviewboard.kde.org/r/103313/diff/2/?file=42637#file42637line1378>
> >
> > Argh. Exit method halfway. I'd prefer reworking the trailing part of the function \
> > (refactoring a bit that is) instead of exiting halfway. Should be as easy as moving the \
> > rest of the function in the else clause AFAICS on short notice.
Normally I would say yes in short functions. But in this case, there is also another rule that \
says "do not do your main computation in the else part", and another one that says "express the \
if then else in positive". There is the main rule that says "make your code readable and \
maintainable", that I think wins here. By the way, there are two infinite loops with break; to \
exit from them to do binary search. You are free to create a patch for them.
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313/#review8683
-----------------------------------------------------------
On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103313/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2011, 10:55 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Basically, what I do is:
> If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
> worked in the past, but in another file). Apply the same strategy with files.
>
> Additional stuff:
> Moved the common calculus of itemSize outside of the if then else.
>
>
> This addresses bugs 213068 and 287847.
> http://bugs.kde.org/show_bug.cgi?id=213068
> http://bugs.kde.org/show_bug.cgi?id=287847
>
>
> Diffs
> -----
>
> kdeui/itemviews/kcategorizedview.cpp 46a1cde
> kutils/kpluginselector.cpp ca0691d
>
> Diff: http://git.reviewboard.kde.org/r/103313/diff/diff
>
>
> Testing
> -------
>
> Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok \
> (I've hit by an amarok start bug). Please, test with other programs.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103313/">http://git.reviewboard.kde.org/r/103313/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2011, 1:12 p.m., <b>Ruurd Pels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103313/diff/2/?file=42637#file42637line1378" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/itemviews/kcategorizedview.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCategorizedView::rowsAboutToBeRemoved(const QModelIndex &parent,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1376</font></th> \
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Argh. Exit method halfway. I'd prefer \
reworking the trailing part of the function (refactoring a bit that is) instead of exiting \
halfway. Should be as easy as moving the rest of the function in the else clause AFAICS on \
short notice.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normally I would say yes in short \
functions. But in this case, there is also another rule that says "do not do your main \
computation in the else part", and another one that says "express the if then else in \
positive". There is the main rule that says "make your code readable and \
maintainable", that I think wins here. By the way, there are two infinite loops with \
break; to exit from them to do binary search. You are free to create a patch for them.</pre> \
<br />
<p>- Jaime Torres</p>
<br />
<p>On December 3rd, 2011, 10:55 a.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2011, 10:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically, what I do \
is: If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
worked in the past, but in another file). Apply the same strategy with files.
Additional stuff:
Moved the common calculus of itemSize outside of the if then else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Krunner config does \
not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an \
amarok start bug). Please, test with other programs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=213068">213068</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=287847">287847</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kcategorizedview.cpp <span style="color: grey">(46a1cde)</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">(ca0691d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103313/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic