[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: fix infinite recurssion in kcategorizedview
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-12-04 8:42:53
Message-ID: 20111204084253.30218.3958 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313/
-----------------------------------------------------------
(Updated Dec. 4, 2011, 8:42 a.m.)
Review request for kdelibs and Rafael Fernández López.
Changes
-------
Make the check for both type of scrollBars run in "parallel", i mean, to check both of them and \
then exit if one of the scroollbars is not present. Done Christoph, Thomas and Alex issues.
(The blank spaces are already removed)
A Question: Could this be done in the rowsInserted method?
Description
-------
Basically, what I do is:
If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
worked in the past, but in another file). Apply the same strategy with files.
Additional stuff:
Moved the common calculus of itemSize outside of the if then else.
This addresses bugs 213068 and 287847.
http://bugs.kde.org/show_bug.cgi?id=213068
http://bugs.kde.org/show_bug.cgi?id=287847
Diffs (updated)
-----
kdeui/itemviews/kcategorizedview.cpp 46a1cde
kutils/kpluginselector.cpp ca0691d
Diff: http://git.reviewboard.kde.org/r/103313/diff/diff
Testing
-------
Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok \
(I've hit by an amarok start bug). Please, test with other programs.
Thanks,
Jaime Torres Amate
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103313/">http://git.reviewboard.kde.org/r/103313/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and Rafael Fernández López.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2011, 8:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make the check for \
both type of scrollBars run in "parallel", i mean, to check both of them and then \
exit if one of the scroollbars is not present. Done Christoph, Thomas and Alex issues.
(The blank spaces are already removed)
A Question: Could this be done in the rowsInserted method?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically, what I do \
is: If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
worked in the past, but in another file). Apply the same strategy with files.
Additional stuff:
Moved the common calculus of itemSize outside of the if then else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Krunner config does \
not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an \
amarok start bug). Please, test with other programs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=213068">213068</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=287847">287847</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kcategorizedview.cpp <span style="color: grey">(46a1cde)</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">(ca0691d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103313/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic