[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add direct support for remote URLs to previewjob
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2011-10-22 0:55:56
Message-ID: 20111022005556.6762.19790 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102929/
-----------------------------------------------------------
(Updated Oct. 22, 2011, 12:55 a.m.)
Review request for kdelibs.
Changes
-------
All comments should be addressed adequately.
Description
-------
This patch allows previewjobs to take a URL in case they understand how to =
deal with that. preview plugis can specify a list of protocols which they s=
upport, this is then matched with the scheme of the URL and if supported th=
e URL is passed directly into the plugin. Otherwise, the file is downloaded=
and passed as local file (this part hasn't changed).
A suitable preview plugin that does the job will be submitted separately to=
kde-runtime.
Is this definitively Frameworks 5 material, or would you be OK with adding =
it to the 4.7 branch? (The latter would mean, we could use vanilla kdelibs =
for Plasma Active 2 in december.)
Diffs (updated)
-----
kdecore/services/kservice.h 040507c =
kio/kio/previewjob.cpp ff6d340 =
Diff: http://git.reviewboard.kde.org/r/102929/diff/diff
Testing
-------
Generating preview for HTTP URLs, for local files and for remote files with=
out a suitable plugin.
Thanks,
Sebastian K=C3=BCgler
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102929/">http://git.reviewboard.kde.org/r/102929/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2011, 12:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All comments should be addressed adequately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch allows previewjobs to take a URL in case they understand how \
to deal with that. preview plugis can specify a list of protocols which they support, \
this is then matched with the scheme of the URL and if supported the URL is passed \
directly into the plugin. Otherwise, the file is downloaded and passed as local file \
(this part hasn't changed).
A suitable preview plugin that does the job will be submitted separately to \
kde-runtime.
Is this definitively Frameworks 5 material, or would you be OK with adding it to the \
4.7 branch? (The latter would mean, we could use vanilla kdelibs for Plasma Active 2 \
in december.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Generating preview for HTTP URLs, for local files and for remote files \
without a suitable plugin.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/services/kservice.h <span style="color: grey">(040507c)</span></li>
<li>kio/kio/previewjob.cpp <span style="color: grey">(ff6d340)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102929/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic