--===============9034829121672405262== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102929/ ----------------------------------------------------------- (Updated Oct. 22, 2011, 12:55 a.m.) Review request for kdelibs. Changes ------- All comments should be addressed adequately. Description ------- This patch allows previewjobs to take a URL in case they understand how to = deal with that. preview plugis can specify a list of protocols which they s= upport, this is then matched with the scheme of the URL and if supported th= e URL is passed directly into the plugin. Otherwise, the file is downloaded= and passed as local file (this part hasn't changed). A suitable preview plugin that does the job will be submitted separately to= kde-runtime. Is this definitively Frameworks 5 material, or would you be OK with adding = it to the 4.7 branch? (The latter would mean, we could use vanilla kdelibs = for Plasma Active 2 in december.) Diffs (updated) ----- kdecore/services/kservice.h 040507c = kio/kio/previewjob.cpp ff6d340 = Diff: http://git.reviewboard.kde.org/r/102929/diff/diff Testing ------- Generating preview for HTTP URLs, for local files and for remote files with= out a suitable plugin. Thanks, Sebastian K=C3=BCgler --===============9034829121672405262== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102929/

Review request for kdelibs.
By Sebastian K=C3=BCgler.

Updated Oct. 22, 2011, 12:55 a.m.

Changes 
All comments should be addressed adequately.

Descripti= on 

This patch allows previewjobs to take a URL in case they und=
erstand how to deal with that. preview plugis can specify a list of protoco=
ls which they support, this is then matched with the scheme of the URL and =
if supported the URL is passed directly into the plugin. Otherwise, the fil=
e is downloaded and passed as local file (this part hasn't changed).

A suitable preview plugin that does the job will be submitted separately to=
 kde-runtime.

Is this definitively Frameworks 5 material, or would you be OK with adding =
it to the 4.7 branch? (The latter would mean, we could use vanilla kdelibs =
for Plasma Active 2 in december.)

Testing <= /h1> 
Generating preview for HTTP URLs, for local files and for re=
mote files without a suitable plugin.

Diffs= (updated)

  • kdecore/services/kservice.h (040507c)
  • kio/kio/previewjob.cpp (ff6d340)

View Diff
--===============9034829121672405262==--