[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: new kded daemon to check .thumbnail directory
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-09-02 15:35:01
Message-ID: 20110902153501.29450.93849 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102083/
-----------------------------------------------------------
(Updated Sept. 2, 2011, 3:35 p.m.)
Review request for kdelibs.
Changes
-------
Now it deletes the oldest files in the .thumbnail directory until the files left use \
less or equal space than the specified.
Summary
-------
This is not yet complete, it is missing the code to delete the files, trailing spaces \
and comments in spanish. (coming in next patch version)
There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just keep the \
lines with an empty traslation? Classes names, method names and variable names are \
OK?
This addresses bug 79943.
http://bugs.kde.org/show_bug.cgi?id=79943
Diffs (updated)
-----
CMakeLists.txt baf36cc
directoryusagenotifier/CMakeLists.txt PRE-CREATION
directoryusagenotifier/COPYING PRE-CREATION
directoryusagenotifier/Messages.sh PRE-CREATION
directoryusagenotifier/README PRE-CREATION
directoryusagenotifier/cleanupdirectory.h PRE-CREATION
directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION
directoryusagenotifier/directoryusagenotifier.h PRE-CREATION
directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION
directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION
directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION
directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION
directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION
directoryusagenotifier/module.h PRE-CREATION
directoryusagenotifier/module.cpp PRE-CREATION
directoryusagenotifier/settings.kcfgc PRE-CREATION
directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION
directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/102083/diff
Testing (updated)
-------
It works as expected.
Thanks,
Jaime Torres
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102083/">http://git.reviewboard.kde.org/r/102083/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2011, 3:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now it deletes the oldest files in the .thumbnail directory until the \
files left use less or equal space than the specified.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is not yet complete, it is missing the code to delete the files, \
trailing spaces and comments in spanish. (coming in next patch version)
There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just keep the \
lines with an empty traslation? Classes names, method names and variable names are \
OK? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works as expected. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=79943">79943</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(baf36cc)</span></li>
<li>directoryusagenotifier/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/COPYING <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/cleanupdirectory.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/cleanupdirectory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier_prefs_base.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/module.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/module.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/settings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/tests/cleanupunittest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102083/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic