This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/

Review request for kdelibs.
By Jaime Torres Amate.

Updated Sept. 2, 2011, 3:35 p.m.

Changes

Now it deletes the oldest files in the .thumbnail directory until the files left use less or equal space than the specified.

Description

This is not yet complete, it is missing the code to delete the files, trailing spaces and comments in spanish. (coming in next patch version)

There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just keep the lines with an empty traslation?
Classes names, method names and variable names are OK?

Testing (updated)

It works as expected.
Bugs: 79943

Diffs (updated)

  • CMakeLists.txt (baf36cc)
  • directoryusagenotifier/CMakeLists.txt (PRE-CREATION)
  • directoryusagenotifier/COPYING (PRE-CREATION)
  • directoryusagenotifier/Messages.sh (PRE-CREATION)
  • directoryusagenotifier/README (PRE-CREATION)
  • directoryusagenotifier/cleanupdirectory.h (PRE-CREATION)
  • directoryusagenotifier/cleanupdirectory.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.h (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.desktop (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.kcfg (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.notifyrc (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier_prefs_base.ui (PRE-CREATION)
  • directoryusagenotifier/module.h (PRE-CREATION)
  • directoryusagenotifier/module.cpp (PRE-CREATION)
  • directoryusagenotifier/settings.kcfgc (PRE-CREATION)
  • directoryusagenotifier/tests/CMakeLists.txt (PRE-CREATION)
  • directoryusagenotifier/tests/cleanupunittest.cpp (PRE-CREATION)

View Diff