[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix missing "..." in KBookmarkAction displayed
From: "Yoann Laissus" <yoann.laissus () gmail ! com>
Date: 2011-08-10 11:52:40
Message-ID: 20110810115240.7590.12435 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 9, 2011, 10:45 p.m., David Faure wrote:
> > Since you're setting iconText, this is about actions into a toolbar, no=
t into a menu, right?
> > =
> > So Qt strips "..." from toolbar button texts? What's the logic there? I=
'm just curious, the patch looks ok, from your description.
> =
> Christoph Feck wrote:
> The logic behind this stripping is to show "Open" instead of "Open...=
" on toolbar buttons.
> =
> Ideally, Qt would only strip trailing ellipsis, but it doesn't, proba=
bly to handle trailing spaces etc.
Yes, and this fix is only for bookmark actions in a toolbar.
- Yoann
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/#review5554
-----------------------------------------------------------
On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102262/
> -----------------------------------------------------------
> =
> (Updated Aug. 9, 2011, 3:32 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> When a bookmark name, is too long, its name is truncated with "..." at th=
e middle.
> But, QAction strip those three dots by default.
> This patch solves this issue by defining imageText. =
> =
> =
> Diffs
> -----
> =
> kio/bookmarks/kbookmarkmenu.cc 873f4a8 =
> =
> Diff: http://git.reviewboard.kde.org/r/102262/diff
> =
> =
> Testing
> -------
> =
> It works with Konqueror and rekonq.
> =
> =
> Thanks,
> =
> Yoann
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102262/">http://git.reviewboard.kde.org/r/102262/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 9th, 2011, 10:45 p.m., <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since you're setting iconText, this is about actions into a toolbar, \
not into a menu, right?
So Qt strips "..." from toolbar button texts? What's the logic there? \
I'm just curious, the patch looks ok, from your description.</pre> </blockquote>
<p>On August 10th, 2011, 10:38 a.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The logic behind this \
stripping is to show "Open" instead of "Open..." on toolbar \
buttons.
Ideally, Qt would only strip trailing ellipsis, but it doesn't, probably to \
handle trailing spaces etc.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, and this fix is \
only for bookmark actions in a toolbar.</pre> <br />
<p>- Yoann</p>
<br />
<p>On August 9th, 2011, 3:32 p.m., Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 3:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a bookmark name, is too long, its name is truncated with \
"..." at the middle. But, QAction strip those three dots by default.
This patch solves this issue by defining imageText. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works with Konqueror and rekonq.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">(873f4a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102262/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic