This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/

On August 9th, 2011, 10:45 p.m., David Faure wrote:

Since you're setting iconText, this is about actions into a toolbar, not into a menu, right?

So Qt strips "..." from toolbar button texts? What's the logic there? I'm just curious, the patch looks ok, from your description.

On August 10th, 2011, 10:38 a.m., Christoph Feck wrote:

The logic behind this stripping is to show "Open" instead of "Open..." on toolbar buttons.

Ideally, Qt would only strip trailing ellipsis, but it doesn't, probably to handle trailing spaces etc.
Yes, and this fix is only for bookmark actions in a toolbar.

- Yoann


On August 9th, 2011, 3:32 p.m., Yoann Laissus wrote:

Review request for kdelibs.
By Yoann Laissus.

Updated Aug. 9, 2011, 3:32 p.m.

Description

When a bookmark name, is too long, its name is truncated with "..." at the middle.
But, QAction strip those three dots by default.
This patch solves this issue by defining imageText. 

Testing

It works with Konqueror and rekonq.

Diffs

  • kio/bookmarks/kbookmarkmenu.cc (873f4a8)

View Diff