[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix logic with clear-button animation in klineedit
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-07-28 4:38:45
Message-ID: 20110728043845.27574.31617 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102095/#review5148
-----------------------------------------------------------
Ship it!
So long as the patch does not cause regressions like the one mentioned by Rolf (bug \
246513), then feel free to ship it.
- Dawit
On July 26, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102095/
> -----------------------------------------------------------
>
> (Updated July 26, 2011, 9:54 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Details:
> - fixes the somewhat incorrect logic in KLineEditButton::animateVisible
> - simplifies KLineEdit::updateClearButtonIcon consequently.
>
>
> This addresses bug 268898.
> http://bugs.kde.org/show_bug.cgi?id=268898
>
>
> Diffs
> -----
>
> kdeui/widgets/klineedit.cpp 8f1c8a4
> kdeui/widgets/klineedit_p.h 95016bd
>
> Diff: http://git.reviewboard.kde.org/r/102095/diff
>
>
> Testing
> -------
>
> tested with klineedittest found in kdelibs/kdeui/tests, this with and without the \
> patch attached to comment #1 of bug 268898, used to actually trigger the mentionned \
> bug. Also tested with other klineEdit implementation such as Dolphin's location \
> bar.
>
> Thanks,
>
> Hugo
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102095/">http://git.reviewboard.kde.org/r/102095/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So long as the patch \
does not cause regressions like the one mentioned by Rolf (bug 246513), then feel \
free to ship it.</pre> <br />
<p>- Dawit</p>
<br />
<p>On July 26th, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated July 26, 2011, 9:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested with klineedittest found in kdelibs/kdeui/tests, this with and \
without the patch attached to comment #1 of bug 268898, used to actually trigger the \
mentionned bug. Also tested with other klineEdit implementation such as Dolphin's \
location bar.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268898">268898</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(8f1c8a4)</span></li>
<li>kdeui/widgets/klineedit_p.h <span style="color: grey">(95016bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic