From kde-core-devel Thu Jul 28 04:38:45 2011 From: "Dawit Alemayehu" Date: Thu, 28 Jul 2011 04:38:45 +0000 To: kde-core-devel Subject: Re: Review Request: Fix logic with clear-button animation in klineedit Message-Id: <20110728043845.27574.31617 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=131182798232634 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5225449675054277826==" --===============5225449675054277826== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102095/#review5148 ----------------------------------------------------------- Ship it! So long as the patch does not cause regressions like the one mentioned by R= olf (bug 246513), then feel free to ship it. - Dawit On July 26, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102095/ > ----------------------------------------------------------- > = > (Updated July 26, 2011, 9:54 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > Details: > - fixes the somewhat incorrect logic in KLineEditButton::animateVisible > - simplifies KLineEdit::updateClearButtonIcon consequently. > = > = > This addresses bug 268898. > http://bugs.kde.org/show_bug.cgi?id=3D268898 > = > = > Diffs > ----- > = > kdeui/widgets/klineedit.cpp 8f1c8a4 = > kdeui/widgets/klineedit_p.h 95016bd = > = > Diff: http://git.reviewboard.kde.org/r/102095/diff > = > = > Testing > ------- > = > tested with klineedittest found in kdelibs/kdeui/tests, this with and wit= hout the patch attached to comment #1 of bug 268898, used to actually trigg= er the mentionned bug. Also tested with other klineEdit implementation such= as Dolphin's location bar. > = > = > Thanks, > = > Hugo > = > --===============5225449675054277826== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102095/

Ship it!

So long as=
 the patch does not cause regressions like the one mentioned by Rolf (bug 2=
46513), then feel free to ship it.

- Dawit


On July 26th, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote:

Review request for kdelibs.
By Hugo Pereira Da Costa.

Updated July 26, 2011, 9:54 p.m.

Descripti= on 

Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.

Testing <= /h1> 
tested with klineedittest found in kdelibs/kdeui/tests, this=
 with and without the patch attached to comment #1 of bug 268898, used to a=
ctually trigger the mentionned bug. Also tested with other klineEdit implem=
entation such as Dolphin's location bar.
Bugs: 268898

Diffs=

  • kdeui/widgets/klineedit.cpp (8f1c8a4)
  • kdeui/widgets/klineedit_p.h (95016bd)

View Diff
--===============5225449675054277826==--