[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Fix KGlobalSettingsTest failure
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2011-07-27 16:31:04
Message-ID: 20110727163104.20219.79416 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102098/
-----------------------------------------------------------
Review request for kdelibs, Aurélien Gâteau and David Faure.
Summary
-------
Since commit b064749a754ec358170ecb7f19828e4216f6e965, KDE palette and font settings \
are only used when running KDE apps in a full KDE session. This makes \
KGlobalSettingsTest fail if the test is not run in a full KDE session, see
http://my.cdash.org/testSummary.php?project=16&name=kdeui-kglobalsettingstest&date=2011-07-27
This commit changes KGlobalSettings' unit test to reflect that change. My first idea \
was to change the unit test such that it verifies the expected behaviour for both \
situations, i.e., apps run in a full KDE session and apps run in some other kind of \
session, but I could not figure out a way to do this without changing the \
KDE_FULL_SESSION environment variable before the unit test executable is run.
In the case that the signal is not expected, I reduced the kWaitForSignal timeout to \
prevent wasting too much time each time the test is run.
Diffs
-----
kdeui/tests/kglobalsettingstest.h 69ed5bf
kdeui/tests/kglobalsettingstest.cpp 464825d
Diff: http://git.reviewboard.kde.org/r/102098/diff
Testing
-------
The test passes here (run by my kde-devel user in a Konsole inside the regular user's \
KDE 4.6 session).
Thanks,
Frank
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102098/">http://git.reviewboard.kde.org/r/102098/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Aurélien Gâteau and David Faure.</div>
<div>By Frank Reininghaus.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since commit b064749a754ec358170ecb7f19828e4216f6e965, KDE palette and \
font settings are only used when running KDE apps in a full KDE session. This makes \
KGlobalSettingsTest fail if the test is not run in a full KDE session, see
http://my.cdash.org/testSummary.php?project=16&name=kdeui-kglobalsettingstest&date=2011-07-27
This commit changes KGlobalSettings' unit test to reflect that change. My first \
idea was to change the unit test such that it verifies the expected behaviour for \
both situations, i.e., apps run in a full KDE session and apps run in some other kind \
of session, but I could not figure out a way to do this without changing the \
KDE_FULL_SESSION environment variable before the unit test executable is run.
In the case that the signal is not expected, I reduced the kWaitForSignal timeout to \
prevent wasting too much time each time the test is run.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The test passes here (run by my kde-devel user in a Konsole inside the \
regular user's KDE 4.6 session).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kglobalsettingstest.h <span style="color: \
grey">(69ed5bf)</span></li>
<li>kdeui/tests/kglobalsettingstest.cpp <span style="color: \
grey">(464825d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102098/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic