From kde-core-devel Wed Jul 27 16:31:04 2011 From: "Frank Reininghaus" Date: Wed, 27 Jul 2011 16:31:04 +0000 To: kde-core-devel Subject: Review Request: Fix KGlobalSettingsTest failure Message-Id: <20110727163104.20219.79416 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=131179703303647 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8271769704446215561==" --===============8271769704446215561== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102098/ ----------------------------------------------------------- Review request for kdelibs, Aur=C3=A9lien G=C3=A2teau and David Faure. Summary ------- Since commit b064749a754ec358170ecb7f19828e4216f6e965, KDE palette and font= settings are only used when running KDE apps in a full KDE session. This m= akes KGlobalSettingsTest fail if the test is not run in a full KDE session,= see http://my.cdash.org/testSummary.php?project=3D16&name=3Dkdeui-kglobalsettin= gstest&date=3D2011-07-27 This commit changes KGlobalSettings' unit test to reflect that change. My f= irst idea was to change the unit test such that it verifies the expected be= haviour for both situations, i.e., apps run in a full KDE session and apps = run in some other kind of session, but I could not figure out a way to do t= his without changing the KDE_FULL_SESSION environment variable before the u= nit test executable is run. In the case that the signal is not expected, I reduced the kWaitForSignal t= imeout to prevent wasting too much time each time the test is run. Diffs ----- kdeui/tests/kglobalsettingstest.h 69ed5bf = kdeui/tests/kglobalsettingstest.cpp 464825d = Diff: http://git.reviewboard.kde.org/r/102098/diff Testing ------- The test passes here (run by my kde-devel user in a Konsole inside the regu= lar user's KDE 4.6 session). Thanks, Frank --===============8271769704446215561== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102098/

Review request for kdelibs, Aur=C3=A9lien G=C3=A2teau and David Faure.=

By Frank Reininghaus.

Descripti= on

Since commit b064749a754ec358170ecb7f19828e4216f6e965, KDE p=
alette and font settings are only used when running KDE apps in a full KDE =
session. This makes KGlobalSettingsTest fail if the test is not run in a fu=
ll KDE session, see

http://my.cdash.org/testSummary.php?project=3D16&name=3Dkdeui-kglobalse=
ttingstest&date=3D2011-07-27

This commit changes KGlobalSettings' unit test to reflect that change. =
My first idea was to change the unit test such that it verifies the expecte=
d behaviour for both situations, i.e., apps run in a full KDE session and a=
pps run in some other kind of session, but I could not figure out a way to =
do this without changing the KDE_FULL_SESSION environment variable before t=
he unit test executable is run.

In the case that the signal is not expected, I reduced the kWaitForSignal t=
imeout to prevent wasting too much time each time the test is run.

Testing <= /h1>

The test passes here (run by my kde-devel user in a Konsole =
inside the regular user's KDE 4.6 session).

Diffs=

kdeui/tests/kglobalsettingstest.h (69ed5bf= )
kdeui/tests/kglobalsettingstest.cpp (46482= 5d)

--===============8271769704446215561==--