[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: konqueror: reset URL when pressing ESC in address
From: "Marcel Partap" <mpartap () gmx ! net>
Date: 2011-07-04 23:29:18
Message-ID: 20110704232918.23490.15049 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
-----------------------------------------------------------
(Updated July 4, 2011, 11:29 p.m.)
Review request for kdelibs and David Faure.
Changes
-------
Patch v4, slimmed down to bare simplicity.
> The URL restored needs to be what was originally entered when the page was \
> rendered. For example, if I typed "about:plugins" to view the available plugins, \
> then typed another address and pressed escape, the address I expect to see is \
> "about:blank" and not a blank location bar, which unfortunately is what this patch \
> will result in.
Actually, I don't think so. To hide the real URL for about:konqueror and about:blank \
on initial opening is ok, but if you press ESCAPE, you get the current view's real \
URL. Imho that makes more sense than adding another variable to track the originally \
entered URL, which would complicate this simply beyond any sanity to catch and \
differentiate all corner cases.
Summary
-------
Attempted patch to make konqueror reset the URL when escape is pressed in the address \
bar. For reasons beyond my grokledge does not always seem to work.
This addresses bug 257841.
https://bugs.kde.org/show_bug.cgi?id=257841
Diffs (updated)
-----
/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388
Diff: http://svn.reviewboard.kde.org/r/6681/diff
Testing
-------
see https://bugs.kde.org/show_bug.cgi?id=257841#c0
Thanks,
Marcel
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6681/">http://svn.reviewboard.kde.org/r/6681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Marcel Partap.</div>
<p style="color: grey;"><i>Updated July 4, 2011, 11:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch v4, slimmed down to bare simplicity. > The URL restored needs \
to be what was originally entered when the page was rendered. > For example, if I \
typed "about:plugins" to view the available plugins, then typed another \
> address and pressed escape, the address I expect to see is \
"about:blank" and not a > blank location bar, which unfortunately is \
what this patch will result in. Actually, I don't think so. To hide the real URL \
for about:konqueror and about:blank on initial opening is ok, but if you press \
ESCAPE, you get the current view's real URL. Imho that makes more sense than \
adding another variable to track the originally entered URL, which would complicate \
this simply beyond any sanity to catch and differentiate all corner cases.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attempted patch to make konqueror reset the URL when escape is pressed \
in the address bar. For reasons beyond my grokledge does not always seem to \
work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see https://bugs.kde.org/show_bug.cgi?id=257841#c0</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=257841">257841</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp <span style="color: \
grey">(1200388)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6681/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic