[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: konqueror: reset URL when pressing ESC in address
From:       Dawit A <adawit () kde ! org>
Date:       2011-06-21 22:28:19
Message-ID: BANLkTi=0EFT_CoYZuaW7=y+fx4U_gnwU8w () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jun 21, 2011 at 2:23 PM, David Faure <faure@kde.org> wrote:

> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
> 
> OK for url() then.
> 
> Re the code above, you're probably right, it wasn't tested with Ctrl+Shift+Tab, \
> only with Ctrl+Tab. 
> 
> /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp<http://svn.reviewboard.kde.org/r/6681/diff/3/?file=46513#file46513line3143> \
> (Diff revision 3)
> 
> bool KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)
> 
> 3143
> 
> m_combo->setURL(url.prettyUrl().startsWith(QLatin1String("about:")) ? "" : \
> url.pathOrUrl()); 
> This should be url.protocol() == QLatin1String("about") :-)
> 
> Yes, it is better to do what David suggests. Unfortunately checking for
"about" that does not address the problem.

The URL restored needs to be what was originally entered when the page was
rendered. For example, if I typed "about:plugins" to view the available
plugins, then typed another address and pressed escape, the address I expect
to see is "about:blank" and not a blank location bar, which unfortunately is
what this patch will result in.


[Attachment #3 (text/html)]

<br><br><div class="gmail_quote">On Tue, Jun 21, 2011 at 2:23 PM, David Faure <span \
dir="ltr">&lt;<a href="mailto:faure@kde.org" \
target="_blank">faure@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">






 <div>
  <div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6681/" \
target="_blank">http://svn.reviewboard.kde.org/r/6681/</a>  </td>
    </tr>
   </tbody></table>
   <br>





 </div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">OK \
for url() then.

Re the code above, you&#39;re probably right, it wasn&#39;t tested with \
Ctrl+Shift+Tab, only with Ctrl+Tab.</pre>  <br>





<div>




<table width="100%" border="0" bgcolor="white" style="border:1px solid \
#C0C0C0;border-collapse:collapse">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid \
#C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">  <a \
href="http://svn.reviewboard.kde.org/r/6681/diff/3/?file=46513#file46513line3143" \
style="color:black;font-weight:bold;text-decoration:underline" \
target="_blank">/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp</a>  <span \
style="font-weight:normal">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
  <tr>

   <td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">bool \
KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size:8pt;line-height:140%;margin:0"></pre></td>  <th bgcolor="#b1ebb0" \
style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" \
align="right"><font size="2">3143</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size:8pt;line-height:140%;margin:0">          \
<span>m_combo</span><span>-&gt;</span><span>setURL</span><span>(</span><span>url</span \
><span>.</span><span>prettyUrl</span><span>().</span><span>startsWith</span><span>(</s \
> pan><span>QLatin1String</span><span>(</span><span>&quot;about:&quot;</span><span>))</span> \
> <span>?</span> <span>&quot;&quot;</span> <span>:</span> \
> <span>url</span><span>.</span><span>pathOrUrl</span><span>());</span></pre>


</td>
  </tr>

 </tbody>

</table>

<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This \
should be url.protocol() == QLatin1String(&quot;about&quot;) :-)</pre></div>


</div></div></blockquote><div>Yes, it is better to do what David suggests. \
Unfortunately checking for &quot;about&quot; that does not address the \
problem.</div><div><br></div><div>The URL restored needs to be what was originally \
entered when the page was rendered. For example, if I typed &quot;about:plugins&quot; \
to view the available plugins, then typed another address and pressed escape, the \
address I expect to see is &quot;about:blank&quot; and not a blank location bar, \
which unfortunately is what this patch will result in.  </div>

<div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]