[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix crash in KDirLister
From: "Commit Hook" <null () kde ! org>
Date: 2011-06-10 7:30:37
Message-ID: 20110610073037.6683.7840 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101560/#review3811
-----------------------------------------------------------
This review has been submitted with commit 4fad3a34f76d33906e018b42ee909877cea0ef2c \
by Aaron Seigo.
- Commit
On June 9, 2011, 4:29 p.m., Sebastian Sauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101560/
> -----------------------------------------------------------
>
> (Updated June 9, 2011, 4:29 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Attached patch fixes a crash reported by gopalK, one of our Calligra@Windows heros.
>
> Backtrace (only one line);
> #0 KDirLister::Private::emitChanges (this=0x13332c70)
> at d:\kderoot\git\kdelibs\kio\kio\kdirlister.cpp:2155
>
> The reason is that kDirListerCache->itemsForDir can return NULL. That is handled in \
> all cases in that file except those two lines. The patch fixes it.
> p.s. whoever pressed "Ship It" please commit the patch for me and backport cause I \
> didn't had the time to get my kdelibs+kdebase setup updated since the latest moves \
> and renames. Thanks in advance :)
>
> Diffs
> -----
>
> kio/kio/kdirlister.cpp d554723
>
> Diff: http://git.reviewboard.kde.org/r/101560/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastian
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101560/">http://git.reviewboard.kde.org/r/101560/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4fad3a34f76d33906e018b42ee909877cea0ef2c by Aaron Seigo.</pre> \
<br />
<p>- Commit</p>
<br />
<p>On June 9th, 2011, 4:29 p.m., Sebastian Sauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Sebastian Sauer.</div>
<p style="color: grey;"><i>Updated June 9, 2011, 4:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attached patch fixes a crash reported by gopalK, one of our \
Calligra@Windows heros.
Backtrace (only one line);
#0 KDirLister::Private::emitChanges (this=0x13332c70)
at d:\kderoot\git\kdelibs\kio\kio\kdirlister.cpp:2155
The reason is that kDirListerCache->itemsForDir can return NULL. That is handled \
in all cases in that file except those two lines. The patch fixes it.
p.s. whoever pressed "Ship It" please commit the patch for me and backport \
cause I didn't had the time to get my kdelibs+kdebase setup updated since the \
latest moves and renames. Thanks in advance :) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kdirlister.cpp <span style="color: grey">(d554723)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101560/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic