--===============6266754644549281626== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101560/#review3811 ----------------------------------------------------------- This review has been submitted with commit 4fad3a34f76d33906e018b42ee909877= cea0ef2c by Aaron Seigo. - Commit On June 9, 2011, 4:29 p.m., Sebastian Sauer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101560/ > ----------------------------------------------------------- > = > (Updated June 9, 2011, 4:29 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > Attached patch fixes a crash reported by gopalK, one of our Calligra@Wind= ows heros. > = > Backtrace (only one line); > #0 KDirLister::Private::emitChanges (this=3D0x13332c70) > at d:\kderoot\git\kdelibs\kio\kio\kdirlister.cpp:2155 > = > The reason is that kDirListerCache->itemsForDir can return NULL. That is = handled in all cases in that file except those two lines. The patch fixes i= t. > = > p.s. whoever pressed "Ship It" please commit the patch for me and backpor= t cause I didn't had the time to get my kdelibs+kdebase setup updated since= the latest moves and renames. Thanks in advance :) > = > = > Diffs > ----- > = > kio/kio/kdirlister.cpp d554723 = > = > Diff: http://git.reviewboard.kde.org/r/101560/diff > = > = > Testing > ------- > = > = > Thanks, > = > Sebastian > = > --===============6266754644549281626== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101560/

This revie=
w has been submitted with commit 4fad3a34f76d33906e018b42ee909877cea0ef2c b=
y Aaron Seigo.

- Commit

On June 9th, 2011, 4:29 p.m., Sebastian Sauer wrote:

Review request for kdelibs.

By Sebastian Sauer.

Updated June 9, 2011, 4:29 p.m.

Descripti= on

Attached patch fixes a crash reported by gopalK, one of our =
Calligra@Windows heros.

Backtrace (only one line);
#0  KDirLister::Private::emitChanges (this=3D0x13332c70)
at d:\kderoot\git\kdelibs\kio\kio\kdirlister.cpp:2155

The reason is that kDirListerCache->itemsForDir can return NULL. That is=
 handled in all cases in that file except those two lines. The patch fixes =
it.

p.s. whoever pressed "Ship It" please commit the patch for me and=
 backport cause I didn't had the time to get my kdelibs+kdebase setup u=
pdated since the latest moves and renames. Thanks in advance :)

Diffs=

kio/kio/kdirlister.cpp (d554723)

--===============6266754644549281626==--