[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: PATCH: Fix most of the login issues with the FTP
From: "David Faure" <faure () kde ! org>
Date: 2011-04-28 8:36:19
Message-ID: 20110428083619.18838.9494 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101173/#review2938
-----------------------------------------------------------
Ship it!
OK, I understand now. Thanks!
- David
On April 27, 2011, 9:27 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101173/
> -----------------------------------------------------------
>
> (Updated April 27, 2011, 9:27 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Summary
> -------
>
> The attached patch addresses most of the FTP login related problems and \
> is a replacement for the previous review request \
> https://git.reviewboard.kde.org/r/100873/. Here are all the changes in \
> this patch:
> - Show the "Remember password" checkbox even after the failure of the \
> first login attempt. [Bug:258888]
> - Always check for cached password before trying to login anonymously \
> unless the "TryAnonymousLoginFirst" flag was set in kio_ftprc. [Bug: \
> 99686, 143488, 124675]
> - Avoid sending the "anonymous" username so it will not be used in the \
> key used to store the password in kwallet.
> - When a url contains a username, but the user chooses to login with a \
> different username in the password dialog, then use redirection to \
> update the client of the change.
> - Store password information in persistent storage if and only if the \
> user checked the "Remember password" checkbox.
>
> This addresses bugs 99686, 124675, 143488, and 258888.
> http://bugs.kde.org/show_bug.cgi?id=99686
> http://bugs.kde.org/show_bug.cgi?id=124675
> http://bugs.kde.org/show_bug.cgi?id=143488
> http://bugs.kde.org/show_bug.cgi?id=258888
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.h 4ccdd4c
> kioslave/ftp/ftp.cpp f7db42b
>
> Diff: http://git.reviewboard.kde.org/r/101173/diff
>
>
> Testing
> -------
>
> - Attempt to login with incorrect username and validate the "Remember \
> password" is actually shown again.
> - Corrected the username information from the password dialog to ensure \
> the client is updated properly about the password change.
> - Clicked on the "Remember password" to store password in persistent \
> storage and retry logging into the same server at a later point.
>
> Thanks,
>
> Dawit
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101173/">http://git.reviewboard.kde.org/r/101173/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">OK, I understand now. Thanks!</pre> <br />
<p>- David</p>
<br />
<p>On April 27th, 2011, 9:27 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 27, 2011, 9:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch addresses most of the FTP login related \
problems and is a replacement for the previous review request \
https://git.reviewboard.kde.org/r/100873/. Here are all the changes in this \
patch:
- Show the "Remember password" checkbox even after the failure of \
the first login attempt. [Bug:258888]
- Always check for cached password before trying to login anonymously \
unless the "TryAnonymousLoginFirst" flag was set in kio_ftprc. \
[Bug: 99686, 143488, 124675]
- Avoid sending the "anonymous" username so it will not be used \
in the key used to store the password in kwallet.
- When a url contains a username, but the user chooses to login with a \
different username in the password dialog, then use redirection to update \
the client of the change.
- Store password information in persistent storage if and only if the user \
checked the "Remember password" checkbox. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Attempt to login with incorrect username and validate the \
"Remember password" is actually shown again.
- Corrected the username information from the password dialog to ensure the \
client is updated properly about the password change.
- Clicked on the "Remember password" to store password in \
persistent storage and retry logging into the same server at a later point. \
</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=99686">99686</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=124675">124675</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=143488">143488</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=258888">258888</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/ftp.h <span style="color: grey">(4ccdd4c)</span></li>
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(f7db42b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101173/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic