From kde-core-devel Thu Apr 28 08:36:19 2011 From: "David Faure" Date: Thu, 28 Apr 2011 08:36:19 +0000 To: kde-core-devel Subject: Re: Review Request: PATCH: Fix most of the login issues with the FTP Message-Id: <20110428083619.18838.9494 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130397983200792 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2187506443181210250==" --===============2187506443181210250== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2938 ----------------------------------------------------------- Ship it! OK, I understand now. Thanks! - David On April 27, 2011, 9:27 p.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101173/ > ----------------------------------------------------------- > = > (Updated April 27, 2011, 9:27 p.m.) > = > = > Review request for kdelibs and David Faure. > = > = > Summary > ------- > = > The attached patch addresses most of the FTP login related problems and i= s a replacement for the previous review request > https://git.reviewboard.kde.org/r/100873/. Here are all the changes in th= is patch: > = > - Show the "Remember password" checkbox even after the failure of the fir= st login attempt. [Bug:258888] > - Always check for cached password before trying to login anonymously unl= ess the "TryAnonymousLoginFirst" > flag was set in kio_ftprc. [Bug: 99686, 143488, 124675] > - Avoid sending the "anonymous" username so it will not be used in the ke= y used to store the password in kwallet. > - When a url contains a username, but the user chooses to login with a di= fferent username in the password dialog, = > then use redirection to update the client of the change. > - Store password information in persistent storage if and only if the use= r checked the "Remember password" checkbox. > = > = > This addresses bugs 99686, 124675, 143488, and 258888. > http://bugs.kde.org/show_bug.cgi?id=3D99686 > http://bugs.kde.org/show_bug.cgi?id=3D124675 > http://bugs.kde.org/show_bug.cgi?id=3D143488 > http://bugs.kde.org/show_bug.cgi?id=3D258888 > = > = > Diffs > ----- > = > kioslave/ftp/ftp.h 4ccdd4c = > kioslave/ftp/ftp.cpp f7db42b = > = > Diff: http://git.reviewboard.kde.org/r/101173/diff > = > = > Testing > ------- > = > - Attempt to login with incorrect username and validate the "Remember pas= sword" is actually shown again. > - Corrected the username information from the password dialog to ensure t= he client is updated properly about the password change. > - Clicked on the "Remember password" to store password in persistent stor= age and retry logging into the same server at a later point. > = > = > Thanks, > = > Dawit > = > --===============2187506443181210250== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101173/

Ship it!

OK, I unde=
rstand now. Thanks!

- David


On April 27th, 2011, 9:27 p.m., Dawit Alemayehu wrote:

Review request for kdelibs and David Faure.
By Dawit Alemayehu.

Updated April 27, 2011, 9:27 p.m.

Descripti= on 

The attached patch addresses most of the FTP login related p=
roblems and is a replacement for the previous review request
https://git.reviewboard.kde.org/r/100873/. Here are all the changes in this=
 patch:

- Show the "Remember password" checkbox even after the failure of=
 the first login attempt. [Bug:258888]
- Always check for cached password before trying to login anonymously unles=
s the "TryAnonymousLoginFirst"
  flag was set in kio_ftprc. [Bug: 99686, 143488, 124675]
- Avoid sending the "anonymous" username so it will not be used i=
n the key used to store the password in kwallet.
- When a url contains a username, but the user chooses to login with a diff=
erent username in the password dialog, =

  then use redirection to update the client of the change.
- Store password information in persistent storage if and only if the user =
checked the "Remember password" checkbox.

Testing <= /h1> 
- Attempt to login with incorrect username and validate the =
"Remember password" is actually shown again.
- Corrected the username information from the password dialog to ensure the=
 client is updated properly about the password change.
- Clicked on the "Remember password" to store password in persist=
ent storage and retry logging into the same server at a later point.
Bugs: 99686, = 124675, = 143488, = 258888

Diffs=

  • kioslave/ftp/ftp.h (4ccdd4c)
  • kioslave/ftp/ftp.cpp (f7db42b)

View Diff
--===============2187506443181210250==--