'Review Request: Fix for connecting to FTP sites through HTTP proxy'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Fix for connecting to FTP sites through HTTP proxy
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-03-07 17:32:14
Message-ID: 20110307173214.10653.14959 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100814/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The attached patch fixes accessing FTP sites through HTTP proxy servers for KDE based \
browsers, such as Konqueror, only. Why only browsers ? Because FTP over HTTP proxy \
sends back HTML pages and not file items. As such, the returned result cannot be \
shown in Dolphin or any application or dialog that relies on the dolphin part.

There is however a much larger issue here that this patch does not address. How to \
support connections to FTP sites in all apps/dialogs that use the dolphinpart when \
such requests are routed through an HTTP proxy ? There is a possibility of using \
proxy tunneling like it is done for HTTPS over HTTP proxy. However, that would \
require kio_ftp being changed to support connecting to an HTTP proxy server. Not a \
minor change. The other option I can think of is to modify the dolphinpart to parse \
the HTML file returned in such cases and create file items out of them, but that too \
is not a complicated solution.

Anyhow, regardless of what could or could not be done to resolve that issue in the \
future, I think that the dolphinpart should at least should check to see if the ftp \
request is going over proxy (KProtocolManager::slaveProtocol) and inform the user \
such action is not supported.


This addresses bug 236630.
    http://bugs.kde.org/show_bug.cgi?id=236630


Diffs
-----

  kioslave/http/http.cpp 0579382 
  kparts/browserrun.cpp 3a062d2 

Diff: http://git.reviewboard.kde.org/r/100814/diff


Testing
-------

Used Konqueror to connect to FTP sites through a local proxy server.


Thanks,

Dawit


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100814/">http://git.reviewboard.kde.org/r/100814/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch fixes accessing FTP sites through HTTP proxy servers \
for KDE based browsers, such as Konqueror, only. Why only browsers ? Because FTP over \
HTTP proxy sends back HTML pages and not file items. As such, the returned result \
cannot be shown in Dolphin or any application or dialog that relies on the dolphin \
part.

There is however a much larger issue here that this patch does not address. How to \
support connections to FTP sites in all apps/dialogs that use the dolphinpart when \
such requests are routed through an HTTP proxy ? There is a possibility of using \
proxy tunneling like it is done for HTTPS over HTTP proxy. However, that would \
require kio_ftp being changed to support connecting to an HTTP proxy server. Not a \
minor change. The other option I can think of is to modify the dolphinpart to parse \
the HTML file returned in such cases and create file items out of them, but that too \
is not a complicated solution.

Anyhow, regardless of what could or could not be done to resolve that issue in the \
future, I think that the dolphinpart should at least should check to see if the ftp \
request is going over proxy (KProtocolManager::slaveProtocol) and inform the user \
such action is not supported.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used Konqueror to connect to FTP sites through a local proxy \
server.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=236630">236630</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/http/http.cpp <span style="color: grey">(0579382)</span></li>

 <li>kparts/browserrun.cpp <span style="color: grey">(3a062d2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100814/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic