--===============2201293085502620819== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- The attached patch fixes accessing FTP sites through HTTP proxy servers for= KDE based browsers, such as Konqueror, only. Why only browsers ? Because F= TP over HTTP proxy sends back HTML pages and not file items. As such, the r= eturned result cannot be shown in Dolphin or any application or dialog that= relies on the dolphin part. There is however a much larger issue here that this patch does not address.= How to support connections to FTP sites in all apps/dialogs that use the d= olphinpart when such requests are routed through an HTTP proxy ? There is a= possibility of using proxy tunneling like it is done for HTTPS over HTTP p= roxy. However, that would require kio_ftp being changed to support connecti= ng to an HTTP proxy server. Not a minor change. The other option I can thin= k of is to modify the dolphinpart to parse the HTML file returned in such c= ases and create file items out of them, but that too is not a complicated s= olution. Anyhow, regardless of what could or could not be done to resolve that issue= in the future, I think that the dolphinpart should at least should check t= o see if the ftp request is going over proxy (KProtocolManager::slaveProtoc= ol) and inform the user such action is not supported. This addresses bug 236630. http://bugs.kde.org/show_bug.cgi?id=3D236630 Diffs ----- kioslave/http/http.cpp 0579382 = kparts/browserrun.cpp 3a062d2 = Diff: http://git.reviewboard.kde.org/r/100814/diff Testing ------- Used Konqueror to connect to FTP sites through a local proxy server. Thanks, Dawit --===============2201293085502620819== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100814/

Review request for kdelibs.
By Dawit Alemayehu.

Descripti= on 

The attached patch fixes accessing FTP sites through HTTP pr=
oxy servers for KDE based browsers, such as Konqueror, only. Why only brows=
ers ? Because FTP over HTTP proxy sends back HTML pages and not file items.=
 As such, the returned result cannot be shown in Dolphin or any application=
 or dialog that relies on the dolphin part.

There is however a much larger issue here that this patch does not address.=
 How to support connections to FTP sites in all apps/dialogs that use the d=
olphinpart when such requests are routed through an HTTP proxy ? There is a=
 possibility of using proxy tunneling like it is done for HTTPS over HTTP p=
roxy. However, that would require kio_ftp being changed to support connecti=
ng to an HTTP proxy server. Not a minor change. The other option I can thin=
k of is to modify the dolphinpart to parse the HTML file returned in such c=
ases and create file items out of them, but that too is not a complicated s=
olution.

Anyhow, regardless of what could or could not be done to resolve that issue=
 in the future, I think that the dolphinpart should at least should check t=
o see if the ftp request is going over proxy (KProtocolManager::slaveProtoc=
ol) and inform the user such action is not supported.

Testing <= /h1> 
Used Konqueror to connect to FTP sites through a local proxy=
 server.
Bugs: 236630

Diffs=

  • kioslave/http/http.cpp (0579382)
  • kparts/browserrun.cpp (3a062d2)

View Diff
--===============2201293085502620819==--