[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add support for building libplasma with GLES2
From: "Marco Martin" <notmart () gmail ! com>
Date: 2011-02-28 11:50:38
Message-ID: 20110228115038.2975.84667 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100705/#review1693
-----------------------------------------------------------
Ship it!
to me seems good.
filling the background of black is something that eventually should do a re=
implementation.
- Marco
On Feb. 25, 2011, 3:29 a.m., Jammy Zhou wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100705/
> -----------------------------------------------------------
> =
> (Updated Feb. 25, 2011, 3:29 a.m.)
> =
> =
> Review request for kdelibs and Plasma.
> =
> =
> Summary
> -------
> =
> After build kwin with GLES2 code path, the kwin binary still has dependen=
cy on libGL.so, which is introduced by libplasma.so. Then we also need to a=
dd GLES2 support to libplasma, so that kwin/plasma only has dependency on l=
ibGLESv2.so in this case. =
> =
> The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is di=
sabled by default, and distributions can turn it on when do packaging for O=
penGL ES2.0 support.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt b8d53de =
> includes/CMakeLists.txt 9954c37 =
> plasma/CMakeLists.txt 8e6b0d7 =
> plasma/glapplet.cpp 00d7caf =
> =
> Diff: http://git.reviewboard.kde.org/r/100705/diff
> =
> =
> Testing
> -------
> =
> After turn the "BUILD_PLASMA_WITH_OPENGLES" option on, kwin-gles has no d=
ependency on libGL.so now. And by default, libplasma still depends on libGL=
.so when run ldd.
> =
> =
> Thanks,
> =
> Jammy
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100705/">http://git.reviewboard.kde.org/r/100705/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">to me seems good. \
filling the background of black is something that eventually should do a \
reimplementation. </pre>
<br />
<p>- Marco</p>
<br />
<p>On February 25th, 2011, 3:29 a.m., Jammy Zhou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Jammy Zhou.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2011, 3:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After build kwin with GLES2 code path, the kwin binary still has \
dependency on libGL.so, which is introduced by libplasma.so. Then we also need to add \
GLES2 support to libplasma, so that kwin/plasma only has dependency on libGLESv2.so \
in this case.
The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is \
disabled by default, and distributions can turn it on when do packaging for OpenGL \
ES2.0 support.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After turn the "BUILD_PLASMA_WITH_OPENGLES" option on, \
kwin-gles has no dependency on libGL.so now. And by default, libplasma still depends \
on libGL.so when run ldd.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b8d53de)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(9954c37)</span></li>
<li>plasma/CMakeLists.txt <span style="color: grey">(8e6b0d7)</span></li>
<li>plasma/glapplet.cpp <span style="color: grey">(00d7caf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100705/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic