[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add support for building libplasma with GLES2
From:       Jammy Zhou <jammy.zhou () linaro ! org>
Date:       2011-02-28 11:40:46
Message-ID: AANLkTimVUKWvKdHNDNvq2swzQQ6qnEjbRoNGp0zaAGrW () mail ! gmail ! com
[Download RAW message or body]

Hi Macro,

I have updated the patch to remove direct OpenGL dependency for libplasma.
Could you please review the patch? (It seems that my mails to kde-core-deve=
l
list were moderated by the server, so I send mail directly to you here)

Regards,
Jammy

On Fri, Feb 25, 2011 at 8:33 PM, Marco Martin <notmart@gmail.com> wrote:

> On Thursday 24 February 2011, Martin Gr=E4=DFlin wrote:
> > >
> > >     I also considered to remove glClear in GLApplet, but I'm not sure
> if
> > >     it will cause some regressions, so I prepared this change.
> > >
> > >     Anyway, waiting for inputs from plasma-devs to make final decisio=
n.
> > >
> > > what's GLApplet originally used for?
> >
> > It allows to write a Plasmoid which can use OpenGL. Apparently there is
> no
> > interest in doing so
>
> opengl on qgraphicsview is so horribly slow that i don't see it going
> anywhere, yeah
>
> > > And if GLApplet is really obsolete, maybe we'd better retire it to
> remove
> > > the dependency of libplasma on libGL. :)
> >
> > Yeah that would be nice. We cannot remove the class altogether, as that
> > would break the ABI, but what should be done is deprecate it and add it
> to
> > the list for removal in libplasma2. To get it free of OpenGL removing t=
he
> > glClear should be enough.
>
> if it's marked as deprecated, the mobile profile would have it already
> removed
> and that's good ;)
>
> Cheers,
> Marco Martin
>

[Attachment #3 (text/html)]

Hi Macro,<br><br>I have updated the patch to remove direct OpenGL dependency for \
libplasma. Could you please review the patch? (It seems that my mails to \
kde-core-devel list were moderated by the server, so I send mail directly to you \
here)<br> <br>Regards,<br>Jammy<br><br><div class="gmail_quote">On Fri, Feb 25, 2011 \
at 8:33 PM, Marco Martin <span dir="ltr">&lt;<a \
href="mailto:notmart@gmail.com">notmart@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im">On \
Thursday 24 February 2011, Martin Gräßlin wrote:<br> &gt; &gt;<br>
&gt; &gt;     I also considered to remove glClear in GLApplet, but I&#39;m not sure \
if<br> &gt; &gt;     it will cause some regressions, so I prepared this change.<br>
&gt; &gt;<br>
&gt; &gt;     Anyway, waiting for inputs from plasma-devs to make final decision.<br>
&gt; &gt;<br>
&gt; &gt; what&#39;s GLApplet originally used for?<br>
&gt;<br>
&gt; It allows to write a Plasmoid which can use OpenGL. Apparently there is no<br>
&gt; interest in doing so<br>
<br>
</div>opengl on qgraphicsview is so horribly slow that i don&#39;t see it going<br>
anywhere, yeah<br>
<div class="im"><br>
&gt; &gt; And if GLApplet is really obsolete, maybe we&#39;d better retire it to \
remove<br> &gt; &gt; the dependency of libplasma on libGL. :)<br>
&gt;<br>
&gt; Yeah that would be nice. We cannot remove the class altogether, as that<br>
&gt; would break the ABI, but what should be done is deprecate it and add it to<br>
&gt; the list for removal in libplasma2. To get it free of OpenGL removing the<br>
&gt; glClear should be enough.<br>
<br>
</div>if it&#39;s marked as deprecated, the mobile profile would have it already \
removed<br> and that&#39;s good ;)<br>
<br>
Cheers,<br>
<font color="#888888">Marco Martin<br>
</font></blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]