[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Fix KWidgetItemeDelegate to correctly update widget
From:       "Thomas Richard" <thomas.richard () proan ! be>
Date:       2011-01-21 18:21:53
Message-ID: 20110121182153.7663.63461 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6401/
-----------------------------------------------------------

Review request for kdelibs, Kevin Ottens and Rafael Fern=C3=A1ndez L=C3=B3p=
ez.


Summary
-------

When a row other then the last got removed from a model, the widgets that a=
re created by the itemdelegate are not moved. This is obviously a big probl=
em when you start removing rows in between. The wrong widgets will show up =
in the wrong rows. This also happens when you insert a new row instead of a=
ppending it.

This patch will update the widgets position of the rows that come behind th=
e one that is inserted/removed. I also had to change QModelIndex to QPersis=
tentModelIndex at one place because the modelindex changes when your remove=
/insert a row in the middle and new widgets would get created.


Diffs
-----

  trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.h 1214155 =

  trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.cpp 1214155 =

  trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate_p.h 1214155 =

  trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool_p.h 1214155 =


Diff: http://svn.reviewboard.kde.org/r/6401/diff


Testing
-------

*Compiling
*Insert a row at the start/in the middle/at the end
*Remove a row at the start/in the middle/at the end

Everything seems to work now.


Thanks,

Thomas


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6401/">http://svn.reviewboard.kde.org/r/6401/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Kevin Ottens and Rafael Fernández López.</div>
<div>By Thomas Richard.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a row other then the last got removed from a model, the widgets \
that are created by the itemdelegate are not moved. This is obviously a big problem \
when you start removing rows in between. The wrong widgets will show up in the wrong \
rows. This also happens when you insert a new row instead of appending it.

This patch will update the widgets position of the rows that come behind the one that \
is inserted/removed. I also had to change QModelIndex to QPersistentModelIndex at one \
place because the modelindex changes when your remove/insert a row in the middle and \
new widgets would get created.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">*Compiling
*Insert a row at the start/in the middle/at the end
*Remove a row at the start/in the middle/at the end

Everything seems to work now.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.h <span style="color: \
grey">(1214155)</span></li>

 <li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.cpp <span style="color: \
grey">(1214155)</span></li>

 <li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate_p.h <span style="color: \
grey">(1214155)</span></li>

 <li>trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool_p.h <span \
style="color: grey">(1214155)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6401/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic