--===============8668964992914641339== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6401/ ----------------------------------------------------------- Review request for kdelibs, Kevin Ottens and Rafael Fern=C3=A1ndez L=C3=B3p= ez. Summary ------- When a row other then the last got removed from a model, the widgets that a= re created by the itemdelegate are not moved. This is obviously a big probl= em when you start removing rows in between. The wrong widgets will show up = in the wrong rows. This also happens when you insert a new row instead of a= ppending it. This patch will update the widgets position of the rows that come behind th= e one that is inserted/removed. I also had to change QModelIndex to QPersis= tentModelIndex at one place because the modelindex changes when your remove= /insert a row in the middle and new widgets would get created. Diffs ----- trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.h 1214155 = trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.cpp 1214155 = trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate_p.h 1214155 = trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool_p.h 1214155 = Diff: http://svn.reviewboard.kde.org/r/6401/diff Testing ------- *Compiling *Insert a row at the start/in the middle/at the end *Remove a row at the start/in the middle/at the end Everything seems to work now. Thanks, Thomas --===============8668964992914641339== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6401/

Review request for kdelibs, Kevin Ottens and Rafael Fern=C3=A1ndez L= =C3=B3pez.
By Thomas Richard.

Descripti= on 

When a row other then the last got removed from a model, the=
 widgets that are created by the itemdelegate are not moved. This is obviou=
sly a big problem when you start removing rows in between. The wrong widget=
s will show up in the wrong rows. This also happens when you insert a new r=
ow instead of appending it.

This patch will update the widgets position of the rows that come behind th=
e one that is inserted/removed. I also had to change QModelIndex to QPersis=
tentModelIndex at one place because the modelindex changes when your remove=
/insert a row in the middle and new widgets would get created.

Testing <= /h1> 
*Compiling
*Insert a row at the start/in the middle/at the end
*Remove a row at the start/in the middle/at the end

Everything seems to work now.

Diffs=

  • trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.h (1214155)
  • trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate.cpp (1214155)
  • trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegate_p.h (1214155)
  • trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool_p.h (1214155)

View Diff
--===============8668964992914641339==--