[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Minor GUI change to rename/overwrite dialog window
From: "Steven Sroka" <thedude_10160 () hotmail ! com>
Date: 2010-09-27 23:05:59
Message-ID: 20100927230559.7568.17222 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5443/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
This is my first submission to KDE. If I am missing something, don't hesitate to tell \
me.
This is a slight GUI change to the rename/overwrite dialog window, just to make it \
more user friendly.
This addresses bug 238942.
https://bugs.kde.org/show_bug.cgi?id=238942
Diffs
-----
/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1179201
Diff: http://svn.reviewboard.kde.org/r/5443/diff
Testing
-------
Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per \
http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
Ran many possible combinations (most if not all) -> move folder to folder, file to \
file, file to folder, folder to file, and paid attention to creation date.
(I actually found a bug with the preview picture that is shown in a certain scenario \
- I will create a bug notice for it on bugs.kde.org soon)
Thanks,
Steven
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5443/">http://svn.reviewboard.kde.org/r/5443/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Steven Sroka.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is my first submission to KDE. If I am missing something, don't \
hesitate to tell me.
This is a slight GUI change to the rename/overwrite dialog window, just to make it \
more user friendly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Correctly Compiled. "Eye ball'ed" Code.
Ran code with all possible '_mode' as per \
http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
Ran many possible combinations (most if not all) -> move folder to folder, file \
to file, file to folder, folder to file, and paid attention to creation date.
(I actually found a bug with the preview picture that is shown in a certain scenario \
- I will create a bug notice for it on bugs.kde.org soon)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=238942">238942</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp <span style="color: \
grey">(1179201)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5443/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic