From kde-core-devel Mon Sep 27 23:05:59 2010 From: "Steven Sroka" Date: Mon, 27 Sep 2010 23:05:59 +0000 To: kde-core-devel Subject: Review Request: Minor GUI change to rename/overwrite dialog window Message-Id: <20100927230559.7568.17222 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=128569729726658 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0388978434769980691==" --===============0388978434769980691== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5443/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- This is my first submission to KDE. If I am missing something, don't hesita= te to tell me. This is a slight GUI change to the rename/overwrite dialog window, just to = make it more user friendly. This addresses bug 238942. https://bugs.kde.org/show_bug.cgi?id=3D238942 Diffs ----- /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1179201 = Diff: http://svn.reviewboard.kde.org/r/5443/diff Testing ------- Correctly Compiled. "Eye ball'ed" Code. Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelib= s-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff Ran many possible combinations (most if not all) -> move folder to folder, = file to file, file to folder, folder to file, and paid attention to creatio= n date. (I actually found a bug with the preview picture that is shown in a certain= scenario - I will create a bug notice for it on bugs.kde.org soon) Thanks, Steven --===============0388978434769980691== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5443/

Review request for kdelibs.

By Steven Sroka.

Descripti= on

This is my first submission to KDE. If I am missing somethin=
g, don't hesitate to tell me.

This is a slight GUI change to the rename/overwrite dialog window, just to =
make it more user friendly.

Testing <= /h1>

Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per http://api.kde.org/4.5-ap=
i/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706b=
ff
Ran many possible combinations (most if not all) -> move folder to folde=
r, file to file, file to folder, folder to file, and paid attention to crea=
tion date.

(I actually found a bug with the preview picture that is shown in a certain=
 scenario - I will create a bug notice for it on bugs.kde.org soon)

Bugs: 238942

Diffs=

/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp View Diff

--===============0388978434769980691==--