[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add option to KGlobalConfig::activate() to skip
From: "David Faure" <faure () kde ! org>
Date: 2010-08-20 13:15:52
Message-ID: 20100820131552.2438.11910 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5072/#review7145
-----------------------------------------------------------
Ship it!
Looks good, thanks. Just missing documentation for the enum values, and it'=
s good to go ;)
- David
On 2010-08-19 15:48:48, George Kiagiadakis wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5072/
> -----------------------------------------------------------
> =
> (Updated 2010-08-19 15:48:48)
> =
> =
> Review request for kdelibs, David Faure and Oswald Buddenhagen.
> =
> =
> Summary
> -------
> =
> This patch modifies KGlobalConfig so that it is possible for applications=
to tell it not to connect to dbus and listen for configuration changes fro=
m other applications. This is useful for kdm, because if QDBusConnection::s=
essionBus() is called while there is no session bus running, a new session =
bus is automatically created, which makes no sense for kdm.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h 1165324 =
> trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1165324 =
> =
> Diff: http://reviewboard.kde.org/r/5072/diff
> =
> =
> Testing
> -------
> =
> Tested with kdm after modifying its call to activate() to use the DontLis=
tenForChanges flag. kdm no longer starts a dbus session.
> =
> =
> Thanks,
> =
> George
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5072/">http://reviewboard.kde.org/r/5072/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, thanks. Just \
missing documentation for the enum values, and it's good to go ;)</pre> <br />
<p>- David</p>
<br />
<p>On August 19th, 2010, 3:48 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, David Faure and Oswald Buddenhagen.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated 2010-08-19 15:48:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch modifies KGlobalConfig so that it is possible for \
applications to tell it not to connect to dbus and listen for configuration changes \
from other applications. This is useful for kdm, because if \
QDBusConnection::sessionBus() is called while there is no session bus running, a new \
session bus is automatically created, which makes no sense for kdm.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with kdm after modifying its call to activate() to use the \
DontListenForChanges flag. kdm no longer starts a dbus session.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h <span style="color: \
grey">(1165324)</span></li>
<li>trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp <span style="color: \
grey">(1165324)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5072/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic